Commenting out more of the marine bufr 2 ioda stuff#1018
Merged
Conversation
guillaumevernieres
added
hera-GW-RT
emcbot
added
hera-GW-RT-Running
guillaumevernieres
requested review from
AndrewEichmann-NOAA and
KatherineLukens-NOAA
|
Automated Global-Workflow GDASApp Testing Results: |
emcbot
added
hera-GW-RT-Failed
|
Automated Global-Workflow GDASApp Testing Results: |
emcbot
added
orion-GW-RT-Failed
apchoiCMD
approved these changes
Apr 3, 2024
Collaborator
|
@guillaumevernieres is it not enough to comment out the in situ obs in the obs yaml? |
Contributor
Author
It's not. It's not finding a python module. The fix was in Shastri's g-w PR, which you took over today. |
danholdaway
added a commit
that referenced
this pull request
Apr 8, 2024
* origin/develop: Use <filesystem> on a non c++17 supported machine (WCOSS ACORN) (#1026) Change generate_com to declare_from_tmpl (#1025) Commenting out more of the marine bufr 2 ioda stuff (#1018) make driver consistent with workflow driver (#1016) Update hashes now that GSI-B is working for EnVar (#1015) Add GitHub CLI to path for CI (#1014) Use _anl rather than _ges dimensions for increments in FV3 increment converter YAML (#1013) Fix inconsistent VIIRS preprocessing test (#1012) remove gdas_ prefix from executable filename in test_gdasapp_fv3jedi_fv3inc (#1010) Bugfix on Broken GHRSST Ioda Converter (#1004) Moved the marine converters to a "safe" place (#1007) restore ATM local ensemble ctest functionality (#1003) Add BUFR2IODA python API converter to prepoceanobs task (#914) Remove sst's from obs proc (#1001) JEDI increment write to cubed sphere history (#983) [End- to End Test code sprint] Add SEVIRI METEOSAT-8 and METEOSAT-11 to end-to-end testing (#766)
DavidNew-NOAA
pushed a commit
that referenced
this pull request
Jan 16, 2026
I wasn't thinking when merging Shastri's PR, it needs its g-w companion PR. @AndrewEichmann-NOAA , we'll have to revert this once you sort out things on the g-w side. - fixes #1017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wasn't thinking when merging Shastri's PR, it needs its g-w companion PR.
@AndrewEichmann-NOAA , we'll have to revert this once you sort out things on the g-w side.