Skip to content

Bugfix on Broken GHRSST Ioda Converter#1004

Merged
guillaumevernieres merged 5 commits into
developfrom
bugfix/ghrsst_datetime_count
Mar 29, 2024
Merged

Bugfix on Broken GHRSST Ioda Converter#1004
guillaumevernieres merged 5 commits into
developfrom
bugfix/ghrsst_datetime_count

Conversation

@apchoiCMD
Copy link
Copy Markdown
Collaborator

@apchoiCMD apchoiCMD commented Mar 28, 2024

This PR should fix the ghrsst ioda converter in ci including;

  • If there are no datetime available then should be 0
  • Add an additional filter to avoid to append unnecessary obs. and datetime
  • New ctest sub-sample was added with the case above.
  • fixes GHRSST Ioda Converter is broken in CI #995

@apchoiCMD apchoiCMD marked this pull request as ready for review March 28, 2024 17:35
guillaumevernieres
guillaumevernieres reviewed Mar 28, 2024
View reviewed changes
Comment thread utils/obsproc/Ghrsst2Ioda.h Outdated
guillaumevernieres
guillaumevernieres reviewed Mar 28, 2024
View reviewed changes
Comment thread utils/obsproc/Ghrsst2Ioda.h
guillaumevernieres
guillaumevernieres reviewed Mar 28, 2024
View reviewed changes
Comment thread utils/obsproc/Ghrsst2Ioda.h
AndrewEichmann-NOAA
AndrewEichmann-NOAA approved these changes Mar 28, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, aside from what Guillaume mentioned

@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Mar 28, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Mar 28, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Mar 28, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Thu Mar 28 14:50:13 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Mar 28 15:42:20 CDT 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Mar 28 16:09:14 CDT 2024
Tests: 89% tests passed, 6 tests failed out of 53
	1737 - test_gdasapp_fv3jedi_fv3inc (Failed)
	1771 - test_gdasapp_atm_jjob_var_run (Failed)
	1772 - test_gdasapp_atm_jjob_var_final (Failed)
	1773 - test_gdasapp_atm_jjob_ens_init (Failed)
	1774 - test_gdasapp_atm_jjob_ens_run (Failed)
	1775 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1004/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Mar 28, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Mar 28, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Thu Mar 28 20:00:20 UTC 2024 on hfe11
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Mar 28 20:53:10 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Mar 28 21:58:24 UTC 2024
Tests: 85% tests passed, 8 tests failed out of 53
	1736 - test_gdasapp_fv3jedi_fv3inc (Failed)
	1757 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
	1770 - test_gdasapp_atm_jjob_var_run (Failed)
	1771 - test_gdasapp_atm_jjob_var_final (Failed)
	1772 - test_gdasapp_atm_jjob_ens_init (Failed)
	1773 - test_gdasapp_atm_jjob_ens_run (Failed)
	1774 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1004/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Mar 28, 2024
@guillaumevernieres guillaumevernieres merged commit db0e86d into develop Mar 29, 2024
@CoryMartin-NOAA CoryMartin-NOAA deleted the bugfix/ghrsst_datetime_count branch March 29, 2024 13:29
danholdaway added a commit that referenced this pull request Apr 8, 2024
@danholdaway
Merge remote-tracking branch 'origin/develop' into feature/use_jcb_atm
b256b0f 
* origin/develop:
  Use <filesystem> on a non c++17 supported machine (WCOSS ACORN) (#1026)
  Change generate_com to declare_from_tmpl (#1025)
  Commenting out more of the marine bufr 2 ioda stuff (#1018)
  make driver consistent with workflow driver (#1016)
  Update hashes now that GSI-B is working for EnVar (#1015)
  Add GitHub CLI to path for CI (#1014)
  Use _anl rather than _ges dimensions for increments in FV3 increment converter YAML (#1013)
  Fix inconsistent VIIRS preprocessing test (#1012)
  remove gdas_ prefix from executable filename in test_gdasapp_fv3jedi_fv3inc (#1010)
  Bugfix on Broken GHRSST Ioda Converter (#1004)
  Moved the marine converters to a "safe" place (#1007)
  restore ATM local ensemble ctest functionality (#1003)
  Add BUFR2IODA python API converter to prepoceanobs task (#914)
  Remove sst's from obs proc (#1001)
  JEDI increment write to cubed sphere history (#983)
  [End- to End Test code sprint] Add SEVIRI METEOSAT-8 and METEOSAT-11 to end-to-end testing (#766)
DavidNew-NOAA pushed a commit that referenced this pull request Jan 16, 2026
@apchoiCMD
Bugfix on Broken GHRSST Ioda Converter (#1004)
4aa8fbe 
#### This PR should fix the ghrsst ioda converter in ci including;
- If there are no datetime available then should be 0
- Add an additional filter to avoid to append unnecessary obs. and
datetime
- New ctest sub-sample was added with the case above.
- fixes #995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guillaumevernieres guillaumevernieres guillaumevernieres left review comments

@AndrewEichmann-NOAA AndrewEichmann-NOAA AndrewEichmann-NOAA approved these changes

Assignees

No one assigned

Labels

hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GHRSST Ioda Converter is broken in CI

4 participants

@apchoiCMD @emcbot @guillaumevernieres @AndrewEichmann-NOAA