Fix inconsistent VIIRS preprocessing test#1012
Conversation
|
@ypwang19 @RussTreadon-NOAA adding this one line causes the test to pass on Hera. Adding this line but making |
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
Simple enough. Wonder why preqc needs to be explicitly set to 2 now and not before. The test passes on Orion without the preqc line. The same was true on non-Rocky 8 Hera nodes. Adding preqc 2 doesn't adversely impact this test on Orion, does it?
|
@RussTreadon-NOAA nope, still passes on Orion with |
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
Thanks, @CoryMartin-NOAA , for confirming that the test still passes on Orion. Nice detective work!
Approve.
* origin/develop: Use <filesystem> on a non c++17 supported machine (WCOSS ACORN) (#1026) Change generate_com to declare_from_tmpl (#1025) Commenting out more of the marine bufr 2 ioda stuff (#1018) make driver consistent with workflow driver (#1016) Update hashes now that GSI-B is working for EnVar (#1015) Add GitHub CLI to path for CI (#1014) Use _anl rather than _ges dimensions for increments in FV3 increment converter YAML (#1013) Fix inconsistent VIIRS preprocessing test (#1012) remove gdas_ prefix from executable filename in test_gdasapp_fv3jedi_fv3inc (#1010) Bugfix on Broken GHRSST Ioda Converter (#1004) Moved the marine converters to a "safe" place (#1007) restore ATM local ensemble ctest functionality (#1003) Add BUFR2IODA python API converter to prepoceanobs task (#914) Remove sst's from obs proc (#1001) JEDI increment write to cubed sphere history (#983) [End- to End Test code sprint] Add SEVIRI METEOSAT-8 and METEOSAT-11 to end-to-end testing (#766)
Closes #993 The `preqc` key was missing from the test YAML and eckit just decided to place some integer in there. This PR should ensure tests pass on all platforms instead of just by chance.
2 participants
Closes #993
The
preqckey was missing from the test YAML and eckit just decided to place some integer in there. This PR should ensure tests pass on all platforms instead of just by chance.