Skip to content

Moved the marine converters to a "safe" place#1007

Merged
guillaumevernieres merged 1 commit into
developfrom
bugfix/move-stuff
Mar 29, 2024
Merged

Moved the marine converters to a "safe" place#1007
guillaumevernieres merged 1 commit into
developfrom
bugfix/move-stuff

Conversation

@guillaumevernieres
Copy link
Copy Markdown
Contributor

No description provided.

@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Mar 28, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Mar 28, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Mar 28, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Thu Mar 28 16:50:25 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Mar 28 17:42:22 CDT 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Mar 28 18:10:37 CDT 2024
Tests: 94% tests passed, 3 tests failed out of 53
	1737 - test_gdasapp_fv3jedi_fv3inc (Failed)
	1771 - test_gdasapp_atm_jjob_var_run (Failed)
	1772 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1007/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Mar 28, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Mar 28, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Thu Mar 28 21:53:28 UTC 2024 on hfe11
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Mar 28 22:44:25 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Mar 28 23:36:21 UTC 2024
Tests: 91% tests passed, 5 tests failed out of 53
	1736 - test_gdasapp_fv3jedi_fv3inc (Failed)
	1757 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
	1770 - test_gdasapp_atm_jjob_var_run (Failed)
	1771 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1007/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Mar 28, 2024
@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor

test_gdasapp_fv3jedi_fv3inc failed because the test looks for executable gdas_fv3jedi_fv3inc.x. This is the wrong name. The executable is fv3jedi_fv3inc.x.

There is an error in gdas.cd/test/fv3jedi//CMakeLists.txt. This file specifies

# Tests
add_test(NAME test_gdasapp_fv3jedi_fv3inc
         COMMAND srun -n6 ${CMAKE_BINARY_DIR}/bin/gdas_fv3jedi_fv3inc.x ${PROJECT_BINARY_DIR}/test/fv3jedi/testinput/gdasapp_fv3jedi_fv3inc.yaml
         WORKING_DIRECTORY ${PROJECT_BINARY_DIR}/test/fv3jedi)

gdas_fv3jedi_fv3inc.x should be fv3jedi_fv3inc.x

The test_gdasapp_atm_jjob_var_run failure is expected. The JEDI ATM sequence is now init, var, fv3inc, and final. The test_gdasapp_atm_jjob_var suite needs to be updated.

test_gdasapp_atm_jjob_var_final failed because the run job failed.

Copy link
Copy Markdown
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @guillaumevernieres for moving marine DA bufr2ioda converters into a marine folder.

Approve.

@guillaumevernieres guillaumevernieres merged commit 135836c into develop Mar 29, 2024
danholdaway added a commit that referenced this pull request Apr 8, 2024
* origin/develop:
  Use <filesystem> on a non c++17 supported machine (WCOSS ACORN) (#1026)
  Change generate_com to declare_from_tmpl (#1025)
  Commenting out more of the marine bufr 2 ioda stuff (#1018)
  make driver consistent with workflow driver (#1016)
  Update hashes now that GSI-B is working for EnVar (#1015)
  Add GitHub CLI to path for CI (#1014)
  Use _anl rather than _ges dimensions for increments in FV3 increment converter YAML (#1013)
  Fix inconsistent VIIRS preprocessing test (#1012)
  remove gdas_ prefix from executable filename in test_gdasapp_fv3jedi_fv3inc (#1010)
  Bugfix on Broken GHRSST Ioda Converter (#1004)
  Moved the marine converters to a "safe" place (#1007)
  restore ATM local ensemble ctest functionality (#1003)
  Add BUFR2IODA python API converter to prepoceanobs task (#914)
  Remove sst's from obs proc (#1001)
  JEDI increment write to cubed sphere history (#983)
  [End- to End Test code sprint] Add SEVIRI METEOSAT-8 and METEOSAT-11 to end-to-end testing (#766)
@guillaumevernieres guillaumevernieres deleted the bugfix/move-stuff branch April 16, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JEDI ATM gfs and gdas prepatmiodaobs breaks with GDASapp hash 33b4cb9

4 participants