Skip to content

RRTMGP in ufs-weather-model#29

Merged
climbfuji merged 9 commits into
NCAR:dtc/developfrom
climbfuji:add_rrtmgp_dom
Mar 26, 2020
Merged

RRTMGP in ufs-weather-model#29
climbfuji merged 9 commits into
NCAR:dtc/developfrom
climbfuji:add_rrtmgp_dom

Conversation

@climbfuji
Copy link
Copy Markdown

@climbfuji climbfuji commented Mar 18, 2020

This PR adds regression tests in PROD and DEBUG mode for RRTMGP in CCPP. The PR also includes an update of the NCAR dtc/develop branch from the NOAA-EMC/ufs-community develop branch.

Supersedes #23.

Associated PRs:

NCAR/ccpp-framework#270
NCAR/ccpp-physics#411 (includes NCAR/ccpp-physics#413; the latter supersedes NCAR/ccpp-physics#400)
NCAR/fv3atm#32 (includes NCAR/fv3atm#26)
#29

For detailed information on the RRTMGP code to be committed, see NCAR/ccpp-physics#400.

For regression testing information, see below.

@climbfuji climbfuji mentioned this pull request Mar 18, 2020
* hera.gnu build target with regression test config rt_gnu.conf (same as used on Cheyenne); this initial version uses the UFS public release v1.0.0 NCEPLIBS
* re-enable IPD REPRO, CCPP REPRO, CCPP PROD regression tests; IPD REPRO and CCPP REPRO are bit-for-bit identical
* bugfixes for some CCPP regression tests (IAU dry mass fixer)
* addition of two-way coupled CCPP regression tests, removal of old IPD Thompson test, addition of several debug tests (Thompson non-aero and GSD suite) to cover more physics options in DEBUG mode
* change logic in rt.sh that COMPILE or APPBUILD lines without a machine name are executed on all machines (similar to what is done for the RUN lines)
…ake.sh to work with the CCPP framework changes
Comment thread parm/ccpp_control.nml.IN
nspinup = 1000
iseed_ca = 0
isppt_deep = .false.
do_RRTMGP = @[DO_RRTMGP]
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just asking, but is ccpp_control the best namelist to put this in? Should there be a separate one for RRTMGP? I see that DO_RRTMGP is set externally such that the other RRTMGP variables become moot if it is set to false.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to avoid a proliferation of namelist templates in parm/ - something that EMC is adamant about for good reasons. Therefore, this makes a lot of sense. Is also done for NoahMP.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. This seems to mark a change from past behavior.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, not. We were asked to combine those as much as it makes sense more than a year ago when merging the initial CCPP version in July 2019.

Copy link
Copy Markdown
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@climbfuji
Copy link
Copy Markdown
Author

Regression testing completed on hera.intel. This is what I did:

  • rsync of the old baseline (20200317) to the new baseline (20200319)
  • run only the RRTMGP tests in PROD, REPRO and DEBUG mode to create a new baseline, make sure all tests complete successfully, copy those regression test baselines into the new 20200319 baseline
  • run full regression test suite (rt.conf) against this 20200319 baseline
  • all tests pass, which means that the addition of RRTMGP does not change the answer of any of the existing physics, and that it reproduces against its own baseline

Regression test config and log used to create the RRTMGP baselines (had to rename rt_rrtmgp.conf to rt_rrtmgp_conf.log for uploading it here):

rt_rrtmgp_conf.log
rt_rrtmgp_create.log

Regression test logs against full=new baseline

rt_full_verify.log

@climbfuji climbfuji merged commit 75145a6 into NCAR:dtc/develop Mar 26, 2020
SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/ufs-weather-model that referenced this pull request Sep 24, 2020
…elop_20200616

Update gsd/develop from develop 2020/06/16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants