changes to SCM for RRTMGP by grantfirl · Pull Request #177 · NCAR/ccpp-scm

grantfirl · 2020-03-21T00:42:40Z

This PR contains the following:

Started from commit e860c96 of the rrtmgp-dev2 branch of dustinswales fork: https://github.com/dustinswales/gmtb-scm-1/tree/rrtmgp-dev2

Merged in the code from PR #176 (contains v4 release code merged with dtc/develop branch).

Followed PRs NCAR/fv3atm#32 and NCAR/ufs-weather-model#29 to work with PRs NCAR/ccpp-framework#270 and NCAR/ccpp-physics#411:

edited ccpp_prebuild_config.py to match changes in FV3's
added do_RRTMGP and edited rrtmgp_root in RRTMGP suite namelist
edited RRTMGP SDF (suite name, removed dcyc2t3_post, version #)
edited GFS_typedefs.[F90,meta] to match FV3's
remove RRTMGP types from gmtb_scm_type_defs.[F90,meta] (moved to Interstitial DDT in GFS_typedefs to match FV3)

Update local forked repo with master

Conflicts: ccpp/framework ccpp/physics

…optics, cloud-optics, and cloud-sampling. Instances of GFS DDTs in the scheme files were removed and replaced with flat-fields.

…anged names.

…-dev2 Conflicts: .gitmodules ccpp/framework ccpp/physics

… rrtmgp-dev2 branch)

…Apollo_setup_intel.csh, twpice_[ice,liq]cloud.nml, plt_scmout.py

grantfirl · 2020-03-21T01:42:30Z

Running the TWPICE case with suites SCM_GFS_v15p2 and SCM_GFS_v15_RRTMGP:

mean SW and LW temperature tendencies over active period (green uses RRTMGP):
profiles_mean_dT_dt_swrad.pdf
profiles_mean_dT_dt_lwrad.pdf

Resultant changes in temperature tendencies due to other processes:

profiles_mean_multi_T_forcing.pdf

… RRTMGP suite and namelist to be based off SCM_GFS_v15p2 suite; update submodule pointers; add multi_run config for RRTMGP; add basic plot_config for GFS_v15p2 vs RRTMGP

grantfirl · 2020-03-25T23:46:30Z

Updated to work with fixed FV3-based PRs. The results from the TWPICE case are actually quite different, but still reasonable:

profiles_mean_dT_dt_lwrad.pdf
profiles_mean_dT_dt_swrad.pdf
profiles_mean_multi_T_forcing.pdf

climbfuji

The changes I am seeing look good to me, but I am surprised I don't see any changes to the build system. If you are using the new capability (include auto-generated CCPP_TYPDEFS.{mk,cmake,sh}) then you can probably remove some files from gmtb-scm's CMakeLists.txt. Like in the fv3atm PR?

grantfirl · 2020-03-26T02:50:06Z

The changes I am seeing look good to me, but I am surprised I don't see any changes to the build system. If you are using the new capability (include auto-generated CCPP_TYPDEFS.{mk,cmake,sh}) then you can probably remove some files from gmtb-scm's CMakeLists.txt. Like in the fv3atm PR?

OK, I'll look at this tomorrow. It seems to work as is, but I'm sure that it could probably be streamlined. As you know, I'm not a build system connoisseur.

climbfuji · 2020-03-26T14:02:50Z

The changes I am seeing look good to me, but I am surprised I don't see any changes to the build system. If you are using the new capability (include auto-generated CCPP_TYPDEFS.{mk,cmake,sh}) then you can probably remove some files from gmtb-scm's CMakeLists.txt. Like in the fv3atm PR?

OK, I'll look at this tomorrow. It seems to work as is, but I'm sure that it could probably be streamlined. As you know, I'm not a build system connoisseur.

I can do that for you if you like and create a PR for your branch.

climbfuji · 2020-03-26T16:13:05Z

The changes I am seeing look good to me, but I am surprised I don't see any changes to the build system. If you are using the new capability (include auto-generated CCPP_TYPDEFS.{mk,cmake,sh}) then you can probably remove some files from gmtb-scm's CMakeLists.txt. Like in the fv3atm PR?

OK, I'll look at this tomorrow. It seems to work as is, but I'm sure that it could probably be streamlined. As you know, I'm not a build system connoisseur.

I can do that for you if you like and create a PR for your branch.

@grantfirl please let me know if you want me to work on this. Thanks!

grantfirl · 2020-03-26T16:16:22Z

The changes I am seeing look good to me, but I am surprised I don't see any changes to the build system. If you are using the new capability (include auto-generated CCPP_TYPDEFS.{mk,cmake,sh}) then you can probably remove some files from gmtb-scm's CMakeLists.txt. Like in the fv3atm PR?

OK, I'll look at this tomorrow. It seems to work as is, but I'm sure that it could probably be streamlined. As you know, I'm not a build system connoisseur.

I can do that for you if you like and create a PR for your branch.

@grantfirl please let me know if you want me to work on this. Thanks!

That'd be great if you have the time. All I saw in the fv3atm PR for CMakeLists.txt was one added line.

climbfuji · 2020-03-26T16:18:43Z

The changes I am seeing look good to me, but I am surprised I don't see any changes to the build system. If you are using the new capability (include auto-generated CCPP_TYPDEFS.{mk,cmake,sh}) then you can probably remove some files from gmtb-scm's CMakeLists.txt. Like in the fv3atm PR?

OK, I'll look at this tomorrow. It seems to work as is, but I'm sure that it could probably be streamlined. As you know, I'm not a build system connoisseur.

I can do that for you if you like and create a PR for your branch.

@grantfirl please let me know if you want me to work on this. Thanks!

That'd be great if you have the time. All I saw in the fv3atm PR for CMakeLists.txt was one added line.

In https://github.com/NCAR/fv3atm/pull/32/files look for the various CMakeLists.txt and makefile changes. But no worries, I will give it a try. Going to check out your grant-rrtmgp branch now, please don't make any changes for the time being.

@grantfirl

Changes to SCM for RRTMGP - updates for @grantfirl's PR

grantfirl · 2020-03-26T19:24:22Z

IMO, this is ready to merge once we have approval from other codeowners.

changes to SCM for RRTMGP

dustinswales and others added 16 commits September 19, 2019 10:53

Merge pull request #1 from NCAR/master

73666b7

Update local forked repo with master

Merge branch 'dtc/develop' of https://github.com/NCAR/gmtb-scm

7bf0bd4

Conflicts: ccpp/framework ccpp/physics

New branch. History corrupted at some point...

3d2b125

Seperated RRTMGP cloud-optics scheme into three new schemes, aerosol-…

3f0a1de

…optics, cloud-optics, and cloud-sampling. Instances of GFS DDTs in the scheme files were removed and replaced with flat-fields.

Updated submodule

a10258f

Moved GFS_rrtmgp_lw_pre.F90 to rrtmgp_lw_pre.F90

db77999

Added by-band fluxes to output.

40c9410

Updated submodules

cdb49ee

Updated .gitmodules

2aacbeb

Changes to ccpp prebuild script. Some rte-rrtmgp source files have ch…

8e093ec

…anged names.

Merge branch 'master' of https://github.com/NCAR/gmtb-scm into rrtmgp…

d3b9a52

…-dev2 Conflicts: .gitmodules ccpp/framework ccpp/physics

Updated submodule.

4118459

Cleaned up a tad.

e860c96

Merge branch 'dtc/develop-release-merge' into grant-rrtmgp

f8c7253

update SCM code to work with RRTMGP (starting from dustinswales fork,…

1fe7d91

… rrtmgp-dev2 branch)

remove some of dustinswales testing files: twpice_[ice,liq]cloud.nc, …

f49d5c4

…Apollo_setup_intel.csh, twpice_[ice,liq]cloud.nml, plt_scmout.py

grantfirl requested review from climbfuji and llpcarson as code owners March 21, 2020 00:42

grantfirl added 2 commits March 20, 2020 21:48

Merge branch 'dtc/develop' into grant-rrtmgp

58029ba

update ccpp_prebuild_config.py in accordance with FV3 version; update…

d657b6c

… RRTMGP suite and namelist to be based off SCM_GFS_v15p2 suite; update submodule pointers; add multi_run config for RRTMGP; add basic plot_config for GFS_v15p2 vs RRTMGP

grantfirl requested a review from dustinswales March 25, 2020 23:46

climbfuji reviewed Mar 26, 2020

View reviewed changes

Update submodule pointers for ccpp-framework and ccpp-physics

2824804

Change logic on how/where kind and type definitions are compiled

c09db8d

dustinswales approved these changes Mar 26, 2020

View reviewed changes

Merge pull request #3 from climbfuji/grant-rrtmgp_dom-mods

f40c9f1

Changes to SCM for RRTMGP - updates for @grantfirl's PR

grantfirl requested a review from climbfuji March 26, 2020 19:24

climbfuji approved these changes Mar 26, 2020

View reviewed changes

grantfirl merged commit dad40fe into NCAR:dtc/develop Mar 26, 2020

dustinswales pushed a commit to dustinswales/ccpp-scm that referenced this pull request May 16, 2022

Merge pull request NCAR#177 from grantfirl/grant-rrtmgp

22adf6a

changes to SCM for RRTMGP

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

changes to SCM for RRTMGP#177

changes to SCM for RRTMGP#177
grantfirl merged 21 commits into
NCAR:dtc/developfrom
grantfirl:grant-rrtmgp

grantfirl commented Mar 21, 2020 •

edited

Loading

Uh oh!

grantfirl commented Mar 21, 2020

Uh oh!

grantfirl commented Mar 25, 2020

Uh oh!

climbfuji left a comment

Uh oh!

grantfirl commented Mar 26, 2020

Uh oh!

climbfuji commented Mar 26, 2020

Uh oh!

climbfuji commented Mar 26, 2020

Uh oh!

grantfirl commented Mar 26, 2020

Uh oh!

climbfuji commented Mar 26, 2020

Uh oh!

grantfirl commented Mar 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

grantfirl commented Mar 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grantfirl commented Mar 21, 2020

Uh oh!

grantfirl commented Mar 25, 2020

Uh oh!

climbfuji left a comment

Choose a reason for hiding this comment

Uh oh!

grantfirl commented Mar 26, 2020

Uh oh!

climbfuji commented Mar 26, 2020

Uh oh!

climbfuji commented Mar 26, 2020

Uh oh!

grantfirl commented Mar 26, 2020

Uh oh!

climbfuji commented Mar 26, 2020

Uh oh!

grantfirl commented Mar 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

grantfirl commented Mar 21, 2020 •

edited

Loading