RRTMGP in CCPP (updates to ccpp_prebuild.py)#270
Merged
Conversation
…tic build is selected
…d metadata2html.py, improved error handling and diagnostic output for ccpp_prebuild.py
…from_dtc_20191210 ufs_public_release: updates from DTC (bugfixes, cleanup, optimization)
…authors ufs_public_release: update version number and authors
…ated unit conversions in ccpp_prebuild.py
…from new to old metadata
…d_20200111 master: fix travis build
…es_log_messages ufs_public_release: bugfix for converting optional attribute from new metadata for ccpp_prebuild.py, correct log message for automated unit conversions
release/public-v4: remove reference to libxml2
…c_develop_20200317 Update master from dtc/develop 2020/03/17
…n modules containing CCPP kind and type definitions to host model
This was referenced Mar 20, 2020
gold2718
approved these changes
Mar 20, 2020
Collaborator
gold2718
left a comment
gold2718
left a comment
There was a problem hiding this comment.
Looks okay (could be optimized but not worth it).
| schemes_with_path.append(os.path.join(relative_path, scheme_filename)) | ||
| schemes_with_abspath.append(os.path.abspath(scheme)) | ||
| # Generate list of schemes with absolute path | ||
| schemes_with_abspath = [ os.path.abspath(scheme) for scheme in schemes ] |
Collaborator
There was a problem hiding this comment.
Is this an unrelated improvement?
Collaborator
Author
There was a problem hiding this comment.
Yes, cleanup (in a second place just below/above as well).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is required for merging RRTMGP into CCPP. It updates/extends the CCPP prebuild script to provide information on CCPP kind and type definitions to the host model.
This is required so that the host model build system (calling/using the ccpp-physics cmake build system) can install and find the Fortran modules containing the definitions of the RRTMGP-internal DDTs, and also the already existing DDTs such as those in
GFS_typedefs.F90. This is an important cleanup, because it means we do not have to manually list and compile the type definitions on the host model side (in addition to being compiled and installed by CCPP).The PR also includes an update of the NCAR dtc/develop branch from the NCAR master branch, as well as an update of the CCPP prebuild scripts to work with Python 3 as described in #271 (this PR was pulled into the current PR and any merge conflicts arising from #271 being based on the release/public-v4 branch were resolved).
Associated PRs:
#270
NCAR/ccpp-physics#411 (includes NCAR/ccpp-physics#413; the latter supersedes NCAR/ccpp-physics#400)
NCAR/fv3atm#32 (includes NCAR/fv3atm#26)
NCAR/ufs-weather-model#29
For detailed information on the RRTMGP code to be committed, see NCAR/ccpp-physics#400.
For regression testing information, see NCAR/ufs-weather-model#29.