RRTMGP in ufs#23
Conversation
dustinswales
requested review from
climbfuji,
grantfirl and
llpcarson
as code owners
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
I don't see any regression test for the new RRTMGP suites. If there were, they would have failed because of the incorrect suite names (see fv3atm PR). I can help to create the regtests based on the control and gfdlmp reg tests with RRTMG.
| ECFLOW_START=/scratch2/NCEPDEV/fv3-cam/Dusan.Jovic/ecflow/bin/ecflow_start.sh | ||
| ECF_PORT=$(( $(id -u) + 1500 )) | ||
| QUEUE=debug | ||
| # ACCNR=fv3-cpu |
| # DTC baseline | ||
| dprefix=/scratch1/BMC/gmtb | ||
| DISKNM=$dprefix/ufs-weather-model/RT | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
Please revert. There are also merge conflict marks in this file, please fix.
| #STMP=$dprefix/stmp4 | ||
| #PTMP=$dprefix/stmp2 | ||
| # | ||
| >>>>>>> 2919f28a56fb3127fca33976c4840cad156be4d1 |
| ROCOTO=false | ||
| ECFLOW=false | ||
| KEEP_RUNDIR=false | ||
| KEEP_RUNDIR=true |
|
@climbfuji |
|
@dustinswales I need to get the current round of PRs merged into the official repositories/branches first before I can return to your PR. There are too many overlapping changes that need to be addressed one after the other. I can set up the regression test when I pull your changes into the latest version of the code if that's ok by you. |
|
@dustinswales I can't pull this PR in, because it contains changes and merge conflict marks in several files that I had asked you to revert. Since this PR does nothing except updating the submodule pointer for fv3atm, is it ok for you to close it (only this PR for ufs-weather-model, of course)? I'll have to create another PR anyway, whether this being a complementary or replacement one. Thanks! Here is the replacement PR: #29 |
|
Thanks! |
|
@climfuji I closed PR #23
…On Wed, Mar 18, 2020 at 6:29 AM Dom Heinzeller ***@***.***> wrote:
@dustinswales <https://github.com/dustinswales> I can't pull this PR in,
because it contains changes and merge conflict marks in several files that
I had asked you to revert. Since this PR does nothing except updating the
submodule pointer for fv3atm, is it ok for you to close it (only this PR
for ufs-weather-model, of course)? I'll have to create another PR anyway,
whether this being a complementary or replacement one. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKNQ2OYSQVEQSGH7ARP76DRIC5DZANCNFSM4K2MXYMA>
.
--
----------------------------------------------------------------------------------
Dustin Swales
Associate Scientist III
CIRES /NOAA-ESRL
(303)-497-7008
dustin.swales@noaa.gov
----------------------------------------------------------------------------------
|
…ructures gsd/develop: handle blocked data structures in init and finalize routines, remove pset logic, metadata cleanup
2 participants
This PR updates the submodule pointers to use fv3atm with RRTMGP enabled CCPP physics:
NCAR/ccpp-physics#400