Implement SNICAR v3 snow albedo model into Noah-MP#187
Merged
cenlinhe merged 37 commits intoNCAR:developfrom May 7, 2025
Merged
Implement SNICAR v3 snow albedo model into Noah-MP#187cenlinhe merged 37 commits intoNCAR:developfrom
cenlinhe merged 37 commits intoNCAR:developfrom
Conversation
Sync with develop branch
Snicar lin
Sync with Develop branch for bug fix
Sync with Develop branch for adding LIS driver folder
sync master branch (Dec2024) to snicar branch
sync with Develop
cenlinhe
commented
Apr 26, 2025
cenlinhe
commented
Apr 26, 2025
Collaborator
Author
|
@tslin2 @RAbolafiaRosenzweig I finished updating this PR, so you can review this one. If we could get this PR done in the next few days, that would be great. Thanks! |
Collaborator
Author
|
Both 2-D CONUS and 1-D Irwin site tests are successful for HRLDAS/NoahMP-SNICAR. |
tslin2
reviewed
May 1, 2025
tslin2
reviewed
May 1, 2025
tslin2
reviewed
May 2, 2025
tslin2
reviewed
May 2, 2025
tslin2
reviewed
May 2, 2025
tslin2
reviewed
May 2, 2025
tslin2
reviewed
May 2, 2025
tslin2
requested changes
May 2, 2025
Collaborator
Author
|
Thanks @tslin2 . I will include your suggested changes. |
Collaborator
Author
|
@tslin2 @RAbolafiaRosenzweig I have included all Tzu-Shun's suggested changes. Please review and approve it at your earliest convenience. Thanks! I will need to wait this NoahMP update to update HRLDAS PR. |
tslin2
approved these changes
May 3, 2025
RAbolafiaRosenzweig
approved these changes
May 6, 2025
Collaborator
RAbolafiaRosenzweig
left a comment
There was a problem hiding this comment.
Changes are applied appropriately for SNICAR v3 snow albedo model.
weiwangncar
pushed a commit
to wrf-model/WRF
that referenced
this pull request
Feb 15, 2026
TYPE: enhancement KEYWORDS: Noah-MP, refactored code SOURCE: Cenlin He (NCAR), Tzu-Shun Lin (NCAR) DESCRIPTION OF CHANGES: This PR includes necessary code changes to couple WRF with the latest refactored Noah-MP v5.1.2 via git submodule mechanisms. Compared to Noah-MP v4.7 in WRF v4.7.1, the Noah-MP v5.1.2 has several added new model physics: 1. add new snow compaction scheme (with namelist option control) developed by Abolafia-Rosenzweig et al 2024 (JAMES; https://doi.org/10.1029/2023MS003869) (NCAR/noahmp#174) 2. improved spring wheat parameters developed by Zhang et al 2023 (GMD; https://doi.org/10.5194/gmd-16-3809-2023) (NCAR/noahmp#175) 3. add new wetland scheme (with namelist option control) developed by Zhang et al 2022 (WRR; https://doi.org/10.1029/2021WR030573) (NCAR/noahmp#186) 4. couple SNICAR v3 snow albedo scheme into Noah-MP (with namelist option control) developed by Lin et al 2024 (JHM; https://doi.org/10.1175/JHM-D-24-0082.1) (NCAR/noahmp#187) 5. add new snow cover scheme (with namelist option control) developed by Abolafia-Rosenzweig et al 2025 (JAMES; doi:10.1029/2024MS004704) (NCAR/noahmp#191) LIST OF MODIFIED FILES: M CMakeLists.txt M Makefile M Registry/Registry.EM_COMMON M Registry/registry.dimspec M Registry/registry.noahmp M arch/Config.pl M chem/depend.chem M chem/module_uoc_dust.F M clean M dyn_em/module_first_rk_step_part1.F M dyn_em/start_em.F M main/CMakeLists.txt M main/depend.common M phys/CMakeLists.txt M phys/Makefile M phys/module_diag_misc.F M phys/module_diagnostics_driver.F M phys/module_physics_init.F M phys/module_sf_clm.F M phys/module_surface_driver.F M phys/noahmp M run/README.namelist M run/README.physics_files M share/mediation_wrfmain.F M share/output_wrf.F M test/em_real/CMakeLists.txt M test/em_real/examples.namelist TESTS CONDUCTED: - The code compiles successfully on NCAR's HPC (Derecho) using both intel and gfortran/gcc compilers. The test runs are also successful including that with activated MMF groundwater scheme, urban scheme, and different combinations of PBL, microphysics, and surface layer schemes. (tested by Cenlin He and Tzu-Shun Lin from NCAR), and has passed the regression tests. - Regression tests have passed. RELEASE NOTE: Coupling with refactored Noah-MP v5.1.2. This new version of NoahMP has a few new options and improvements compared to the previous Noah-MP v4.7 in WRF v4.7.1. See PR for details. --------- Co-authored-by: Massimo D'isidoro <49653612+massimodisidoro@users.noreply.github.com> Co-authored-by: dudhia <dudhia@ucar.edu> Co-authored-by: Yuxuan Xie <77427610+cug-xyx@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to implement SNICAR v3 snow albedo model into Noah-MP. The SNICAR model follows the code that is implemented in the Community Land Model (CLM) done by this study (He et al. 2024 JAMES, https://doi.org/10.1029/2023MS003861) and in this CLM PR : ESCOMP/CTSM#1861
The reference of this SNICAR coupling with Noah-MP v5 is here (Lin et al., 2025 JHM): https://doi.org/10.1175/JHM-D-24-0082.1
The original code implementation in Noah-MP is done by Tzu-Shun Lin (NCAR) with updates from Cenlin He (NCAR).
Both 2-D CONUS and 1-D Irwin site tests are successful for HRLDAS/NoahMP-SNICAR.
Specifically, this PR includes the SNICAR module for the following snow albedo calculation features: