add new snow compaction scheme from Abolafia-Rosenzweig et al 2024#174
Merged
cenlinhe merged 3 commits intoNCAR:developfrom Jan 30, 2025
Merged
add new snow compaction scheme from Abolafia-Rosenzweig et al 2024#174cenlinhe merged 3 commits intoNCAR:developfrom
cenlinhe merged 3 commits intoNCAR:developfrom
Conversation
Closed
Collaborator
Author
|
I just realized that I missed the update in the LIS/noahmp driver folder part for this, and will update this PR soon. |
cenlinhe
commented
Jan 30, 2025
| NoahmpIO%C5_SNOWCOMPACT_TABLE = undefined_real | ||
| NoahmpIO%DM_SNOWCOMPACT_TABLE = undefined_real | ||
| NoahmpIO%ETA0_SNOWCOMPACT_TABLE = undefined_real | ||
| NoahmpIO%SNOWCOMPACTm_AR24_TABLE = undefined_real |
Collaborator
Author
There was a problem hiding this comment.
these 6 lines (with "AR24" as suffix) are the new added compaction parameters. The other lines for this part is just formatting changes to line up the code.
Collaborator
Author
|
@tslin2 @RAbolafiaRosenzweig I have added changes to the lis driver folder. Now this PR is ready for your review. thanks! |
tslin2
reviewed
Jan 30, 2025
RAbolafiaRosenzweig
approved these changes
Jan 30, 2025
Collaborator
RAbolafiaRosenzweig
left a comment
RAbolafiaRosenzweig
left a comment
There was a problem hiding this comment.
Code updates look correct and test simulations provide expected results.
weiwangncar
pushed a commit
to wrf-model/WRF
that referenced
this pull request
Feb 15, 2026
TYPE: enhancement KEYWORDS: Noah-MP, refactored code SOURCE: Cenlin He (NCAR), Tzu-Shun Lin (NCAR) DESCRIPTION OF CHANGES: This PR includes necessary code changes to couple WRF with the latest refactored Noah-MP v5.1.2 via git submodule mechanisms. Compared to Noah-MP v4.7 in WRF v4.7.1, the Noah-MP v5.1.2 has several added new model physics: 1. add new snow compaction scheme (with namelist option control) developed by Abolafia-Rosenzweig et al 2024 (JAMES; https://doi.org/10.1029/2023MS003869) (NCAR/noahmp#174) 2. improved spring wheat parameters developed by Zhang et al 2023 (GMD; https://doi.org/10.5194/gmd-16-3809-2023) (NCAR/noahmp#175) 3. add new wetland scheme (with namelist option control) developed by Zhang et al 2022 (WRR; https://doi.org/10.1029/2021WR030573) (NCAR/noahmp#186) 4. couple SNICAR v3 snow albedo scheme into Noah-MP (with namelist option control) developed by Lin et al 2024 (JHM; https://doi.org/10.1175/JHM-D-24-0082.1) (NCAR/noahmp#187) 5. add new snow cover scheme (with namelist option control) developed by Abolafia-Rosenzweig et al 2025 (JAMES; doi:10.1029/2024MS004704) (NCAR/noahmp#191) LIST OF MODIFIED FILES: M CMakeLists.txt M Makefile M Registry/Registry.EM_COMMON M Registry/registry.dimspec M Registry/registry.noahmp M arch/Config.pl M chem/depend.chem M chem/module_uoc_dust.F M clean M dyn_em/module_first_rk_step_part1.F M dyn_em/start_em.F M main/CMakeLists.txt M main/depend.common M phys/CMakeLists.txt M phys/Makefile M phys/module_diag_misc.F M phys/module_diagnostics_driver.F M phys/module_physics_init.F M phys/module_sf_clm.F M phys/module_surface_driver.F M phys/noahmp M run/README.namelist M run/README.physics_files M share/mediation_wrfmain.F M share/output_wrf.F M test/em_real/CMakeLists.txt M test/em_real/examples.namelist TESTS CONDUCTED: - The code compiles successfully on NCAR's HPC (Derecho) using both intel and gfortran/gcc compilers. The test runs are also successful including that with activated MMF groundwater scheme, urban scheme, and different combinations of PBL, microphysics, and surface layer schemes. (tested by Cenlin He and Tzu-Shun Lin from NCAR), and has passed the regression tests. - Regression tests have passed. RELEASE NOTE: Coupling with refactored Noah-MP v5.1.2. This new version of NoahMP has a few new options and improvements compared to the previous Noah-MP v4.7 in WRF v4.7.1. See PR for details. --------- Co-authored-by: Massimo D'isidoro <49653612+massimodisidoro@users.noreply.github.com> Co-authored-by: dudhia <dudhia@ucar.edu> Co-authored-by: Yuxuan Xie <77427610+cug-xyx@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to implement the new snow compaction scheme from Abolafia-Rosenzweig et al 2024, which updates the original Noah-MP snow compaction scheme based on Anderson (1976). This scheme has been added to Noah-MP as a new physics option: "snow_compaction_option".
snow_compaction_option = 1 (original Noah-MP snow compaction scheme based on Anderson 1976);
snow_compaction_option = 2 (updated Noah-MP snow compaction scheme based on Abolafia-Rosenzweig et al 2024);
The default snow compaction scheme is currently set to the updated scheme (snow_compaction_option = 2).
Effects of this change: the new scheme generally enhances snow compaction rate, which leads to a better simulation for snow depth and snow density comparing with the SNOTEL observations over the western US.
Reference: Abolafia-Rosenzweig, R., C. He, F. Chen, and M. Barlage (2024), Evaluating and enhancing snow compaction process in the Noah-MP land surface model, Journal of Advances in Modeling Earth Systems, 6, e2023MS003869, https://doi.org/10.1029/2023MS003869
This PR was originally submitted as #148, but with some modifications for naming and formatting as well as small bug fixes.