Implement SNICAR v3 snow albedo model#257
Merged
cenlinhe merged 83 commits intoNCAR:developfrom May 7, 2025
Merged
Conversation
Merge develop branch to master branch
re-structure HRLDAS repo
…d soil timestep control update
Snicar lin
Sync with Develop
cenlinhe
commented
Apr 28, 2025
Collaborator
Author
|
Both 2-D CONUS and 1-D Irwin site tests are successful for HRLDAS/NoahMP-SNICAR. |
tslin2
reviewed
May 1, 2025
tslin2
reviewed
May 1, 2025
tslin2
reviewed
May 1, 2025
tslin2
requested changes
May 1, 2025
Collaborator
Author
|
Thanks @tslin2 . I will include your suggested changes. I will link the updated NoahMP Github commit once the NoahMP PR is approved and merged for this SNICAR updates. |
Collaborator
Author
|
@tslin2 @RAbolafiaRosenzweig I have included all Tzu-Shun's suggested changes. Please review and approve it at your earliest convenience. Thanks! I will update the NoahMP linked commit once the PR in NoahMP Github is approved and merged. |
tslin2
approved these changes
May 3, 2025
RAbolafiaRosenzweig
approved these changes
May 6, 2025
Collaborator
RAbolafiaRosenzweig
left a comment
There was a problem hiding this comment.
Changes are applied appropriately for SNICAR v3 snow albedo model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to implement SNICAR v3 snow albedo model into HRLDAS/Noah-MP. This HRLDAS PR is associated with the Noah-MP PR (NCAR/noahmp#187).
Both 2-D CONUS and 1-D Irwin site tests are successful for HRLDAS/NoahMP-SNICAR.
The SNICAR model follows the code that is implemented in the Community Land Model (CLM) done by this study (He et al. 2024 JAMES, https://doi.org/10.1029/2023MS003861) and in this CLM PR : ESCOMP/CTSM#1861
The reference of this SNICAR coupling with Noah-MP v5 is here (Lin et al., 2025 JHM): https://doi.org/10.1175/JHM-D-24-0082.1
The original code implementation in Noah-MP is done by Tzu-Shun Lin (NCAR) with updates from Cenlin He (NCAR).
Specifically, this PR includes the SNICAR module for the following snow albedo calculation features: