Add wetland scheme of Zhang et al 2022 WRR#186
Conversation
|
Thanks for updating this PR from my previous one. I approve this pull request. |
|
point scale 1-year test simulations are successful on Derecho. I will also submit a PR to HRLDAS that comes together with this NoahMP wetland source code update after this one is approved and merged, so that I can update noahmp link on HRLDAS side. |
|
@tslin2 @RAbolafiaRosenzweig Could either of you approve PR if everything looks good? Thanks! |
|
OK, I have fixed all the issues mentioned above, please take a look to see if it can be approved. thanks! |
| ! ---------------------------------------------------------------------- | ||
|
|
||
| ! compute saturated area fraction, based on top-layer soil moisture | ||
| SoilSaturateFrac = SoilSfcSatFracMax * (SoilLiqWater(1)/SoilMoistureSat(1)) |
There was a problem hiding this comment.
@cenlinhe @CharlesZheZhang If the topmodel-based runoff schemes like option 1 and the wetland model is on
SoilSfcSatFracMax will use the same values in both modules, right?
Should it be a separate parameter name or is it okay?
There was a problem hiding this comment.
Yes, currently they will use the same value. I agree that we probably need a separate parameter name with a regional-calibrated value for wetland. This can be done in the future.
There was a problem hiding this comment.
I think no matter what, this wetland scheme would replace surface runoff and infiltration on top of other surface runoff schemes; it is fine now.
It may be better to consider this another surface runoff scheme in the future, given that other runoff schemes will be useless.
There was a problem hiding this comment.
agreed. This issue will be solved once we have a wetland flag to identify the land type to only do wetland over grids with existing subgrid wetland areas.
There was a problem hiding this comment.
Or maybe add the if statement only if SoilSfcSatFracMax >0 to run the wetland module to prevent running wetland everywhere
There was a problem hiding this comment.
This is one possible way but only works for 2D FSATMX input map not for using a uniform value from NoahmpTable.TBL.
TYPE: enhancement KEYWORDS: Noah-MP, refactored code SOURCE: Cenlin He (NCAR), Tzu-Shun Lin (NCAR) DESCRIPTION OF CHANGES: This PR includes necessary code changes to couple WRF with the latest refactored Noah-MP v5.1.2 via git submodule mechanisms. Compared to Noah-MP v4.7 in WRF v4.7.1, the Noah-MP v5.1.2 has several added new model physics: 1. add new snow compaction scheme (with namelist option control) developed by Abolafia-Rosenzweig et al 2024 (JAMES; https://doi.org/10.1029/2023MS003869) (NCAR/noahmp#174) 2. improved spring wheat parameters developed by Zhang et al 2023 (GMD; https://doi.org/10.5194/gmd-16-3809-2023) (NCAR/noahmp#175) 3. add new wetland scheme (with namelist option control) developed by Zhang et al 2022 (WRR; https://doi.org/10.1029/2021WR030573) (NCAR/noahmp#186) 4. couple SNICAR v3 snow albedo scheme into Noah-MP (with namelist option control) developed by Lin et al 2024 (JHM; https://doi.org/10.1175/JHM-D-24-0082.1) (NCAR/noahmp#187) 5. add new snow cover scheme (with namelist option control) developed by Abolafia-Rosenzweig et al 2025 (JAMES; doi:10.1029/2024MS004704) (NCAR/noahmp#191) LIST OF MODIFIED FILES: M CMakeLists.txt M Makefile M Registry/Registry.EM_COMMON M Registry/registry.dimspec M Registry/registry.noahmp M arch/Config.pl M chem/depend.chem M chem/module_uoc_dust.F M clean M dyn_em/module_first_rk_step_part1.F M dyn_em/start_em.F M main/CMakeLists.txt M main/depend.common M phys/CMakeLists.txt M phys/Makefile M phys/module_diag_misc.F M phys/module_diagnostics_driver.F M phys/module_physics_init.F M phys/module_sf_clm.F M phys/module_surface_driver.F M phys/noahmp M run/README.namelist M run/README.physics_files M share/mediation_wrfmain.F M share/output_wrf.F M test/em_real/CMakeLists.txt M test/em_real/examples.namelist TESTS CONDUCTED: - The code compiles successfully on NCAR's HPC (Derecho) using both intel and gfortran/gcc compilers. The test runs are also successful including that with activated MMF groundwater scheme, urban scheme, and different combinations of PBL, microphysics, and surface layer schemes. (tested by Cenlin He and Tzu-Shun Lin from NCAR), and has passed the regression tests. - Regression tests have passed. RELEASE NOTE: Coupling with refactored Noah-MP v5.1.2. This new version of NoahMP has a few new options and improvements compared to the previous Noah-MP v4.7 in WRF v4.7.1. See PR for details. --------- Co-authored-by: Massimo D'isidoro <49653612+massimodisidoro@users.noreply.github.com> Co-authored-by: dudhia <dudhia@ucar.edu> Co-authored-by: Yuxuan Xie <77427610+cug-xyx@users.noreply.github.com>
3 participants
This PR is a refined version of the code implementation for the wetland scheme from Zhang et al. 2022 (https://doi.org/10.1029/2021WR030573) following an earlier PR (#97). This PR resolves the code merging conflicts in the earlier PR.
Original PR and implementation: Zhe Zhang (NCAR)
Refined PR and implementation: Cenlin He (NCAR)
The wetland code has been refactored to the newest version of Noah-MP LSM.
To activate the wetland, a new namelist entry has been added:
wetland_option = 1 : for single point
wetland_option = 2 : for 2D regional
Initial test with the refactor wetland code at single point is conducted with the Fen site data from SK, Canada, for three years (see attached pdf).
Test_Wetland_Code_Output.pdf