Closed
Conversation
Collaborator
|
Hi Ronnie, a few minor suggestions:
Thanks! |
RAbolafiaRosenzweig
force-pushed
the
snow_compaction
branch
from
06c8335 to
dcd874b
Compare
RAbolafiaRosenzweig
force-pushed
the
snow_compaction
branch
3 times, most recently
from
47128ba to
aaee8fe
Compare
Collaborator
Author
|
These 4 suggestions have been accepted & incorporated. |
tslin2
reviewed
Nov 14, 2024
tslin2
reviewed
Nov 14, 2024
tslin2
reviewed
Nov 14, 2024
tslin2
reviewed
Nov 14, 2024
tslin2
reviewed
Nov 14, 2024
tslin2
reviewed
Nov 14, 2024
tslin2
reviewed
Nov 14, 2024
Collaborator
|
Should this enhancement of SnowCompactBurdenFac to be considered an option in the Noah-MP parameter table or a new physics option in the namelist? One physics, but two options for the SnowCompactBurdenFac parameter (original and enhanced) in the Noah-MP parameter table? Thanks. |
tslin2
reviewed
Nov 15, 2024
tslin2
reviewed
Nov 15, 2024
snow_compaction snow_compaction snow_compaction snow_compaction snow_compaction snow_compaction snow_compaction snow_compaction snow_compaction snow_compaction
RAbolafiaRosenzweig
force-pushed
the
snow_compaction
branch
from
aaee8fe to
d411268
Compare
Closed
Collaborator
tslin2
reviewed
Jan 23, 2025
Comment on lines
+124
to
+125
| SNLIQMAXFRAC, SWEMAXGLA, & | ||
| SNLIQMAXFRAC, SWEMAXGLA, & |
Collaborator
There was a problem hiding this comment.
These two lines are duplicate
tslin2
reviewed
Jan 23, 2025
| SnowCoverGlacierMod.o: ../utility/Machine.o NoahmpVarType.o ConstantDefineMod.o | ||
| SnowWaterMainGlacierMod.o: ../utility/Machine.o NoahmpVarType.o ConstantDefineMod.o SnowfallBelowCanopyMod.o \ | ||
| SnowpackCompactionMod.o SnowLayerCombineMod.o SnowLayerDivideMod.o \ | ||
| SnowpackCompactionMod.o SnowpackCompactionARMod.o SnowLayerCombineMod.o SnowLayerDivideMod.o \ |
Collaborator
There was a problem hiding this comment.
Has SnowWaterMainGlacierMod.F90 been revised? I can not see the code changes for this file
Collaborator
|
I have created an update PR for this snow compaction update with some additional formatting, naming, and bug fixes according to the review comments. The new PR is here: #174 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables new snow compaction physics option using the enhanced scheme developed by Abolafia-Rosenzweig et al. (2024). This new physics option can be used by defining SNOW_COMPACTION_OPTION=2 in the namelist file.
Abolafia-Rosenzweig, R., He, C., Chen, F., Barlage, M., 2024. Evaluating and Enhancing Snow Compaction Process in the Noah-MP Land Surface Model. J Adv Model Earth Syst 16, e2023MS003869. https://doi.org.10.1029/2023MS003869