UFS-dev PR#262#626
Merged
Merged
Conversation
grantfirl
requested review from
dustinswales,
hertneky,
mkavulich and
scrasmussen
as code owners
scrasmussen
approved these changes
Oct 17, 2025
Member
scrasmussen
left a comment
scrasmussen
left a comment
There was a problem hiding this comment.
These changes look good! Built all the cases locally just to double check they worked with the renaming.
Merged
hertneky
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SOURCE: @grantfirl
DESCRIPTION OF CHANGES:
ISSUE: N/A
ASSOCIATED PRs:
NCAR/ccpp-physics#1167
TESTS CONDUCTED: List tests done as appropriate. Delete if not used.
SCM RTs
This PR catches the NCAR:main branch up with changes from the ufs-community:ufs/dev branch.
Associated ufs/dev PR:
Associated ufsatm PR:
Associated NCAR PR:
REGRESSION TEST CHANGES: I'm not sure if there should be RT changes or not because the UFS-based changes included a changed diagnostic that changed pretty much all UFS RT baselines. However, the SCM doesn't have the same diagnostic. It's possible that some UFS RTs would have changed results minimally even without the diagnostic change, however.