Skip to content

UFS-dev PR#305#630

Merged
grantfirl merged 21 commits into
NCAR:mainfrom
grantfirl:ufs-dev-PR305
Nov 7, 2025
Merged

UFS-dev PR#305#630
grantfirl merged 21 commits into
NCAR:mainfrom
grantfirl:ufs-dev-PR305

Conversation

@grantfirl
Copy link
Copy Markdown
Collaborator

@grantfirl grantfirl commented Oct 20, 2025

SOURCE: @grantfirl

DESCRIPTION OF CHANGES:

  • Code changes need for RRTMGP v1.8

ISSUE: None

ASSOCIATED PRs:
NCAR/ccpp-physics#1168
NCAR/ccpp-physics#1172

TESTS CONDUCTED: SCM/UFS RTs

This PR catches the NCAR:main branch up with changes from the ufs-community:ufs/dev branch.

Associated ufs/dev PR:

Associated ufsatm PR:

Associated NCAR PR:


REGRESSION TEST CHANGES: Assuming all RRTMGP-based suites should change results.

@grantfirl
Copy link
Copy Markdown
Collaborator Author

grantfirl commented Oct 20, 2025

Note: This should not be merged until we figure out what to do with the RRTMGP data. See NCAR/ccpp-physics#1168 (comment) for more details.

Edit: I tar'ed up the RRTMGP data files, added them as a release asset to v7.0, wrote a script to download them and stage them within scm/data/physics_input_data and modified physics namelists to point to them in their new location. All RRTMGP RTs should run now.

@grantfirl
Copy link
Copy Markdown
Collaborator Author

@scrasmussen @hertneky Not sure if we want to upload artifacts from the last PR merge to use them in this PR, or should we wait until #628 is finished?

Copy link
Copy Markdown
Collaborator

@hertneky hertneky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
Used new script to get new radiation data and ran RTs. All ran successfully, namely the RRTMGP suites

@hertneky
Copy link
Copy Markdown
Collaborator

@scrasmussen @hertneky Not sure if we want to upload artifacts from the last PR merge to use them in this PR, or should we wait until #628 is finished?

I don't think we need to wait on #628, but I'll let @scrasmussen chime in if he has an opinion.

@scrasmussen
Copy link
Copy Markdown
Member

@scrasmussen @hertneky Not sure if we want to upload artifacts from the last PR merge to use them in this PR, or should we wait until #628 is finished?

@scrasmussen @hertneky Not sure if we want to upload artifacts from the last PR merge to use them in this PR, or should we wait until #628 is finished?

I don't think we need to wait on #628, but I'll let @scrasmussen chime in if he has an opinion.

Hi, no need to wait on PR #628! Not quite ready to be merged and it shouldn't effect this one.

Copy link
Copy Markdown
Member

@scrasmussen scrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@scrasmussen
Copy link
Copy Markdown
Member

@grantfirl I think the new get-artifacts was failing because the default number of artifact names that it returns is 30. It wasn't breaking for me because I was testing right after the main branch had created the artifacts. But as other PRs ran CI and create PR artifacts, it pushed the main artifacts out of the 30 range. I'll submit a fix to this momentarily

@grantfirl grantfirl merged commit 2ef185d into NCAR:main Nov 7, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants