Update calculation of time-averaged radiation variables#262
Merged
Conversation
…rect sub-fhswr/fhlwr bucket radiation values
…om *_post routines
… into feature/rad-fix
…: support multiple instances by making is_initialized a host-model variable
…ry.fv3.*: support multiple instances by making is_initialized a host-model variable" This reverts commit 4c558e1.
This reverts commit 5c3886a.
This reverts commit 6b40c48.
This reverts commit c25d36c.
This reverts commit 08857a8.
This reverts commit 73e032e.
…time step" This reverts commit 48278a5.
This reverts commit 3110557.
This reverts commit 3b2a01a.
This reverts commit 6619587.
Collaborator
Author
|
@dustinswales @rhaesung @Qingfu-Liu I think that this is finally ready to go again. I merged in some fixes from @dustinswales and I needed to fix some things for running in debug mode related to optional arguments afterward. I've tested this in the SCM and the radiation diagnostics still "smooth out" in time. |
grantfirl
changed the title
rhaesung
approved these changes
Sep 3, 2025
Qingfu-Liu
approved these changes
Sep 23, 2025
|
All tests ran successfully at ufs-community/ufs-weather-model#2660. @rhaesung @grantfirl can you go ahead to merge this pr? |
Merged
This was referenced Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces #241 since I think that @LarissaReames-NOAA no longer works for NOAA. The original description of hers follows and all credit goes to her for this work.
This PR fixes incorrect diagnostic output for fhzero-averaged radiation variables output in the weather model and computed from the CCPP 'fluxr' array. Presently, there is a significant "sawtooth" appearance to these fields when output from ufs-weather-model (such as dswrf_ave and ulwrf_avetoa) when we expect smoother lines with jumps only at fhzero diagnostic reset times. Here is an example of the present (OLD) result and the result from the current PR (FIX) of DWRF_AVE from a 24-hour control C48 weather model regression test forecast.
To accomplish this, I moved all fluxr computations from the rrtmg_post and rrtmgp_post routines to the dcyc2t3_run routine, thus it is called, and fluxr accumulates radiation values, at every large dynamics time step. I did my best to move documentation of the variables to the dcyc2t3_run header as well.
Issue(s) addressed
Testing
Ran full ufs-weather-model regression test suite on Hera. See log files here:
/scratch1/NAGAPE/hpc-wof1/lreames/ufs-weather-model/tests/logs/log_hera. You can also see forecast output from these tests in/scratch1/NCEPDEV/stmp2/Larissa.Reames/FV3_RT/rt_4109245All regression tests fail as sfcf*.nc files, as well as post-processed grib2 files as a result, are not identical. New weather model baselines will be necessary.