Update calculation of time-averaged radiation variables#941
Merged
BrianCurtis-NOAA merged 35 commits intoOct 7, 2025
Conversation
…te at sub-radiation-timestep output frequency.
…t.F90 in to GFS_radiation_post.F90 in ccpp/physics, requiring changes to all suites.
… bug fix and workaround for bad tsfco NOAA-EMC#916 (NOAA-EMC#896) * Parallel IO enhancements from GDIT * Add SW clear-sky downward flux at surface to available diagnostics * fix compilation error in GFS_diagnostics.F90 * update atmos_cubed_sphere to turn ENABLE_PARALLELRESTART OFF by default to avoid RT errors on some platforms (Hera, Hercules at least) * ccpp-physics - wet() bug fix and workaround for bad tsfco --------- Co-authored-by: Dustin Swales <dustin.swales@noaa.gov> Co-authored-by: Samuel Trahan <samuel,trahan@noaa.gov>
This was referenced Mar 21, 2025
grantfirl
changed the title
Collaborator
|
Could we get this subcomponent PR reviewed so that it's ready to go when we begin to process WM PR #2660 sometime next week? I'm seeing that not all checks are passing so I wanted to make sure that this subcomponent PR is actually ready. |
DusanJovic-NOAA
approved these changes
Sep 25, 2025
Collaborator
Author
|
@jkbk2004 I'm doublechecking that this compiles on Ursa since there is the CI error related to ccpp_prebuild. Should be an easy fix, assuming that something is actually wrong. |
Collaborator
Author
|
@jkbk2004 Looks like there was only 1 small error in a new suite. Should be fixed now. |
Contributor
|
@grantfirl ufs-community/ccpp-physics#262 ufs-community/ccpp-physics#246 has been merged. Please update the submodule pointer for ccpp-physics (ufs-community/ccpp-physics@0722a9d) and revert the .gitmodules file in preparation for the merge. |
FernandoAndrade-NOAA
requested review from
BrianCurtis-NOAA and
NickSzapiro-NOAA
NickSzapiro-NOAA
approved these changes
Oct 7, 2025
BrianCurtis-NOAA
approved these changes
Oct 7, 2025
grantfirl
added a commit
to dustinswales/fv3atm
that referenced
this pull request
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
All work contained in this PR is from @LarissaReames-NOAA. This PR was opened to shuttle this work through the UFS merge queue because @LarissaReames-NOAA was a probationary fire.
This PR fixes incorrect diagnostic output for fhzero-averaged radiation output variables. Presently, there is a significant "sawtooth" appearance to these fields (such as dswrf_ave and ulwrf_avetoa) when we expect smoother lines with jumps only at fhzero diagnostic reset times. Here is an example of the present (OLD) result and the result from the current PR (FIX) from a 24-hour S2S regression test forecast.
Issue(s) addressed
fixes a problem found in investigating ufs-weather-model/ufs-community/ufs-weather-model#1767
Testing
Ran full regression test suite on Hera. See log files here: /scratch1/NAGAPE/hpc-wof1/lreames/ufs-weather-model/tests/logs/log_hera
Forecast output can be found here: /scratch1/NCEPDEV/stmp2/Larissa.Reames/FV3_RT/rt_4109245
All regression tests fail as sfcf*.nc files, as well as post-processed grib2 files as a result, are not identical. New baselines will be necessary.
Dependencies
ufs-community/ccpp-physics#262