Fix RAP (Grell Freitas) decomp b4b issues#942
Merged
SamuelTrahanNOAA merged 5 commits intoJun 17, 2022
Conversation
…for-bit identical decomp results with GF
SamuelTrahanNOAA
requested review from
ChunxiZhang-NOAA,
climbfuji,
grantfirl,
haiqinli,
hannahcbarnes,
mkavulich,
mzhangw and
panll
as code owners
hannahcbarnes
approved these changes
Jun 10, 2022
Contributor
hannahcbarnes
left a comment
hannahcbarnes
left a comment
There was a problem hiding this comment.
Thanks for help finding the b4b issue.
Contributor
Author
|
I didn't do it. Dom did. I'm replacing his PR so he can use his 4 hours a week for something more critical. |
ChunxiZhang-NOAA
approved these changes
Jun 10, 2022
haiqinli
approved these changes
Jun 10, 2022
Collaborator
|
Thanks for taking care of getting those changes in @SamuelTrahanNOAA! |
grantfirl
approved these changes
Jun 14, 2022
17 tasks
…ugfix/gf_decomp_b4b
…OAA/ccpp-physics into bugfix/gf_decomp_b4b
6 tasks
SMoorthi-emc
approved these changes
Jun 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces #933 and is identical, except that it comes from another fork. All of this work comes from @climbfuji
Bug fixes in physics/cu_gf_deep.F90 and physics/cu_gf_driver.F90 for bit-for-bit identical results with GF when changing the MPI decomposition. Instead of using the pefc value of last column (pefc was a scalar), which is incorrect, turn pefc into a vector of length horizontal_loop_extent and use the correct value in GF deep convection.
Minor formatting cleanup in removal of unused symbols/code.
Associated PRs:
NOAA-EMC/ufsatm#553
ufs-community/ufs-weather-model#1257
For regression testing, see ufs-community/ufs-weather-model#1243