moninshoc.meta missing mfpbl.f dependency#934
Merged
SamuelTrahanNOAA merged 1 commit intoJun 17, 2022
Conversation
SamuelTrahanNOAA
requested review from
AlexBelochitski-NOAA,
ChunxiZhang-NOAA,
climbfuji,
grantfirl,
mkavulich,
mzhangw and
panll
as code owners
This was referenced Jun 6, 2022
Collaborator
|
@SamuelTrahanNOAA Does this affect the release branch and the suites planned for release as part of CCPP v6? |
Contributor
Author
|
Only if the release branch has JM's Neptune changes. |
Collaborator
|
The release does not have JM's NEPTUNE changes. Thanks for the prompt reply. |
SMoorthi-emc
approved these changes
Jun 7, 2022
grantfirl
approved these changes
Jun 14, 2022
Collaborator
|
@SamuelTrahanNOAA I realize that this PR doesn't change the baseline and #942 does, but since this is just one line, could this be combined into #942 for the sake of saving UFS code managers work? |
Contributor
Author
|
This has been merged into #942 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent addition of "module" statements at the top of some files broke moninshoc. This adds a dependency so moninshoc will compile.
Fixes #935