Fix RAP (Grell Freitas) decomp b4b issues#156
Merged
SamuelTrahanNOAA merged 39 commits intoJun 14, 2022
Merged
Conversation
…lux_bug Fix scm specified surface flux bug
Update rte-rrtmgp submodule + SCM-only bugfix
NRL Neptune model 32-bit physics support
Add prognostic cumulus closure description in saSAS
SamuelTrahanNOAA
requested review from
christinaholtNOAA,
haiqinli,
hannahcbarnes,
joeolson42,
mdtoyNOAA,
middlecoff,
tanyasmirnova and
zhanglikate
as code owners
mdtoyNOAA
approved these changes
Jun 14, 2022
15 tasks
tanyasmirnova
approved these changes
Jun 14, 2022
| alpha3 = 0.75 | ||
| beta3 = -0.15 | ||
| pefc=0. | ||
| pefc(:)=0. |
There was a problem hiding this comment.
Coding question. Is it important that pefc has an i component since it is output from this subroutine? I am trying to understand why pefc needs to have its component defined, but pef and pefb do not.
Collaborator
Author
There was a problem hiding this comment.
In cu_gf_deep_run, ccnloss needs to have a different value for each i. There are several ways to do that, and this is the one Dom chose.
hannahcbarnes
approved these changes
Jun 14, 2022
haiqinli
approved these changes
Jun 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the GF scheme that prevented bit-for-bit reproducibility. This is the same as:
NCAR#942