Fix RAP (Grell Freitas) decomp b4b issues#553
Merged
DusanJovic-NOAA merged 11 commits intoJun 17, 2022
Conversation
This was referenced Jun 14, 2022
17 tasks
This was referenced Jun 15, 2022
junwang-noaa
approved these changes
Jun 17, 2022
climbfuji
approved these changes
Jun 17, 2022
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
The GF code changes in ccpp-physics look like mine, I don't know anything about the moninshoc or dycore updates.
Collaborator
|
Please list dycore PR as a dependency. |
DusanJovic-NOAA
approved these changes
Jun 17, 2022
Contributor
Author
I just added it. The merge is waiting on that dependency now; the ccpp-physics PR is already merged. |
Contributor
Author
|
This PR is ready to be merged. The two PRs on which it depends have been merged, and the branch is updated to point to the head of the authoritative atmos_cubed_sphere and ccpp/physics branches. |
Contributor
Author
|
I'd like @jkbk2004 to confirm he's ready for code managers to merge this. |
Collaborator
|
Sure! we can merge in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #543, which is identical, but comes from another fork. All of this work comes from @climbfuji
Description
Update .gitmodules and submodule pointer for ccpp-physics for code review and testing of the changes described in NCAR/ccpp-physics#933.
Issue(s) addressed
See ufs-community/ufs-weather-model#1243.
Testing
See ufs-community/ufs-weather-model#1243.
Dependencies
waiting on NCAR/ccpp-physics#933
NOAA-GFDL/GFDL_atmos_cubed_sphere#194