Skip to content

Update ccpp-scm to work with ccpp-physics branch ccpp_convective_transport_tracers_cleanup from @climbfuji#275

Closed
climbfuji wants to merge 3 commits into
NCAR:mainfrom
climbfuji:ccpp_convective_transport_tracers_cleanup
Closed

Update ccpp-scm to work with ccpp-physics branch ccpp_convective_transport_tracers_cleanup from @climbfuji#275
climbfuji wants to merge 3 commits into
NCAR:mainfrom
climbfuji:ccpp_convective_transport_tracers_cleanup

Conversation

@climbfuji
Copy link
Copy Markdown
Collaborator

As the title says:

Update ccpp-scm to work with ccpp-physics branch ccpp_convective_transport_tracers_cleanup from @climbfuji

This PR contains the cumulative changes to run ccpp-scm with the branch ccpp_convective_transport_tracers_cleanup (see NCAR/ccpp-physics#752). This includes several updates in CCPP-SCM due to recent commits.

This PR will get updated whenever NCAR/ccpp-physics#752 gets updated until it is time to merge.

@grantfirl
Copy link
Copy Markdown
Collaborator

@climbfuji It looks like most of the changes in this PR were duplicated in #276 (which was done because a user asked to have the ccpp-scm up-to-date ASAP). I don't know how many of the changes in this PR are specifically for ccpp-physics PR #752 vs just catching up to main. Sorry for making this more difficult!

@climbfuji
Copy link
Copy Markdown
Collaborator Author

@climbfuji It looks like most of the changes in this PR were duplicated in #276 (which was done because a user asked to have the ccpp-scm up-to-date ASAP). I don't know how many of the changes in this PR are specifically for ccpp-physics PR #752 vs just catching up to main. Sorry for making this more difficult!

Looks like PR #276 contained everything that was needed. Not even my changes in scm/src/scm_type_defs.F90 are necessary. Will close this PR.

@climbfuji climbfuji closed this Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants