Updated sfc_nst.f, sfc_nst.meta, module_nst_water_prop.f90 and flake_…#588
Merged
Conversation
YihuaWu-NOAA
requested review from
JulieSchramm,
climbfuji,
grantfirl and
llpcarson
as code owners
…move_zorl_interstitial
…move_zorl_interstitial
climbfuji
requested changes
Mar 18, 2021
grantfirl
reviewed
Mar 18, 2021
Contributor
Author
|
Hi, Dom,
I have answered the questions below for the parts I have modified.
Please fix whitespaces (align &) at the end
Yes, it has been fixed.
You need to revert all these changes.
Yes, they have been reverted.
Thanks! Regards
*Yihua----------------------------------------------------Yihua Wu, Ph D*I.M.
Systems Group
NOAA/NWS/NCEP/EMC
5830 University Research Court, Room: 2031
College Park, Maryland 20740, USA
Phone: (301)-683-3691
Fax: (301)-683-3703
…On Thu, Mar 18, 2021 at 11:30 AM Dom Heinzeller ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In physics/sfc_nst.f
<#588 (comment)>:
> @@ -8,12 +8,15 @@ module sfc_nst
! \brief This subroutine is empty since there are no procedures that need to be done to initialize the GFS NSST code.
!! This subroutine is empty since there are no procedures that need to be done to initialize the GFS NSST code.
+!!
+!! \section arg_table_sfc_nst_init Argument Table
If you add this, you should also add the htmlinclude statements. I
recommend reverting this change, the _init routine is not used.
------------------------------
In physics/sfc_nst.f
<#588 (comment)>:
> !!
subroutine sfc_nst_init
end subroutine sfc_nst_init
! \brief This subroutine is empty since there are no procedures that need to be done to finalize the GFS NSST code.
!! This subroutine is empty since there are no procedures that need to be done to finalize the GFS NSST code.
+!! \section arg_table_sfc_nst_finalize Argument Table
If you add this, you should also add the htmlinclude statements. I
recommend reverting this change, the _finalize routine is not used.
------------------------------
In physics/sfc_nst.f
<#588 (comment)>:
> @@ -655,10 +660,14 @@ module sfc_nst_pre
!! The NSST scheme is one of the three schemes used to represent the
!! surface in the GFS physics suite. The other two are the Noah land
!! surface model and the sice simplified ice model.
+!!
Same as above.
------------------------------
In physics/sfc_nst.f
<#588 (comment)>:
> !!
subroutine sfc_nst_pre_init
end subroutine sfc_nst_pre_init
+!! \section arg_table_sfc_nst_finalize Argument Table
Same as above.
------------------------------
In physics/sfc_nst.f
<#588 (comment)>:
> @@ -754,11 +764,15 @@ module sfc_nst_post
! \defgroup GFS_NSST_POST GFS Near-Surface Sea Temperature Post
!! \brief Brief description of the parameterization
+!!
+!! \section arg_table_sfc_nst_post_init Argument Table
Same as above.
------------------------------
In physics/sfc_nst.f
<#588 (comment)>:
> !!
subroutine sfc_nst_post_init
end subroutine sfc_nst_post_init
! \brief Brief description of the subroutine
+!!
+!! \section arg_table_sfc_nst_post_finalize Argument Table
Same as above.
------------------------------
In physics/sfc_nst.f
<#588 (comment)>:
> @@ -773,7 +787,7 @@ end subroutine sfc_nst_post_finalize
! \section NSST_detailed_post_algorithm Detailed Algorithm
! @{
subroutine sfc_nst_post_run &
- & ( im, rlapse, tgice, wet, icy, oro, oro_uf, nstf_name1, &
+ & ( im, rlapse, tgice, wet, lake,icy, oro, oro_uf, nstf_name1, &
Please fix whitespaces (align &) at the end
------------------------------
In physics/sfc_nst.meta
<#588 (comment)>:
> @@ -118,7 +118,7 @@
standard_name = surface_air_pressure
long_name = surface pressure
units = Pa
- dimensions = (horizontal_loop_extent)
You need to revert all these changes (horizontal_loop_extent) -->
(horizontal_dimension). For variables in the metadata tables for the _run
routines, you must use (horizontal_loop_extent).
Conversely, for variables in the metadata tables for the _init/
_timestep_init,/_timestep_finalize/_finalize routines, you must use
horizontal_dimension
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#588 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANJBYQHXRZ333WGF3IW3FALTEIMABANCNFSM4YZRNQMA>
.
|
Collaborator
Thanks, Yihua. The only changes left are the |
Contributor
Author
|
Hi, Dom,
Those are from the version I checked out earlier. I did not add them.
But, they have been removed.
Thanks!
*Yihua----------------------------------------------------Yihua Wu, Ph D*I.M.
Systems Group
NOAA/NWS/NCEP/EMC
5830 University Research Court, Room: 2031
College Park, Maryland 20740, USA
Phone: (301)-683-3691
Fax: (301)-683-3703
…On Thu, Mar 18, 2021 at 6:32 PM Dom Heinzeller ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In physics/sfc_nst.f
<#588 (comment)>:
> !!
subroutine sfc_nst_post_init
end subroutine sfc_nst_post_init
! \brief Brief description of the subroutine
+!!
+!! \section arg_table_sfc_nst_post_finalize Argument Table
This one is also still left.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#588 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANJBYQD45JFZEOSLGZE4P3TTEJ5P5ANCNFSM4YZRNQMA>
.
|
…reading_aerosol_interp_noahmp_init
…rface_composites_pre_run
…move_zorl_interstitial
13 tasks
…ace composites from ocean to water
…e no longer existant Interstitial%dtdtc
…ji/ccpp-physics into rename_surface_composites_ocean_water
…tion, redifined lake to use_flake
Collaborator
|
This PR is currently in a messed-up state, it shows 40 changed files, many of them from the last PR that went into master. I am adding the "do not merge" label until this is resolved. |
Collaborator
|
@YihuaWu-NOAA this could be a github bug. I am going to close your PR and immediately reopen it, maybe that fixes it ... |
Collaborator
|
closing/reopening to see if this fixes a github bug |
Collaborator
Collaborator
|
This PR has been pulled into #629 and will be merged automatically as part of it. Do not merge manually. |
13 tasks
Collaborator
|
@YihuaWu-NOAA to expedite the process of merging this, we are going to work with PR #629 from now on. Please make sure that all changes are as you wanted them to be, if not let me know. I only fixed the github issues and reverted a few unnecessary formatting changes. Thanks! |
climbfuji
added a commit
that referenced
this pull request
Apr 19, 2021
Wrapper for #588 (Updated sfc_nst.f, sfc_nst.meta, module_nst_water_prop.f90 and flake_driver.F90)
HelinWei-NOAA
pushed a commit
to HelinWei-NOAA/ccpp-physics
that referenced
this pull request
Feb 26, 2023
…th the Thompson microphysics scheme (NCAR#588) * version worked for producing nifa and nwfa * added mraerosol in typedef * use ltaersol=.true. and merra2 * Add consistency check for Thompson aerosol options to GFS_typedefs.F90 * using field table instead of code change for mraerosol * Updates and bug fixes for Thompson-Merra2 Co-authored-by: anning.cheng <anning.cheng@noaa.gov> Co-authored-by: Dom Heinzeller <climbfuji@ymail.com> Co-authored-by: AnningCheng-NOAA <48297505+AnningCheng-NOAA@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…driver.F90