Updated sfc_nst.f, sfc_nst.meta, module_nst_water_prop.f90 and flake_… #588
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,12 +8,15 @@ module sfc_nst | |
|
|
||
| ! \brief This subroutine is empty since there are no procedures that need to be done to initialize the GFS NSST code. | ||
| !! This subroutine is empty since there are no procedures that need to be done to initialize the GFS NSST code. | ||
| !! | ||
| !! \section arg_table_sfc_nst_init Argument Table | ||
|
climbfuji marked this conversation as resolved.
Outdated
|
||
| !! | ||
| subroutine sfc_nst_init | ||
| end subroutine sfc_nst_init | ||
|
|
||
| ! \brief This subroutine is empty since there are no procedures that need to be done to finalize the GFS NSST code. | ||
| !! This subroutine is empty since there are no procedures that need to be done to finalize the GFS NSST code. | ||
| !! \section arg_table_sfc_nst_finalize Argument Table | ||
|
climbfuji marked this conversation as resolved.
Outdated
|
||
| !! | ||
| subroutine sfc_nst_finalize | ||
| end subroutine sfc_nst_finalize | ||
|
|
@@ -28,7 +31,7 @@ end subroutine sfc_nst_finalize | |
| subroutine sfc_nst_run & | ||
| & ( im, hvap, cp, hfus, jcal, eps, epsm1, rvrdm1, rd, rhw0, & ! --- inputs: | ||
| & pi, sbc, ps, u1, v1, t1, q1, tref, cm, ch, & | ||
| & prsl1, prslki, prsik1, prslk1, wet, lake, xlon, sinlat, & | ||
|
Contributor
There was a problem hiding this comment. Maybe be "lake" is bad name here I recommend using something like "use_flake".
Contributor
There was a problem hiding this comment. An additional question is whether "flake" and "nsst" models should coexist? I think DA over lakes needs nsst (needs to determine lake skin temperature). Does flake provide skin temperature? Radiation needs skin temperature too.
Contributor
There was a problem hiding this comment.
@YihuaWu-NOAA @SMoorthi-emc : Agree with Moorthi, it is a topic to discuss and the decide if whether "flake" and "nsst" models should coexist? |
||
| & stress, & | ||
| & sfcemis, dlwflx, sfcnsw, rain, timestep, kdt, solhr,xcosz, & | ||
| & wind, flag_iter, flag_guess, nstf_name1, nstf_name4, & | ||
|
|
@@ -47,7 +50,7 @@ subroutine sfc_nst_run & | |
| ! call sfc_nst ! | ||
| ! inputs: ! | ||
| ! ( im, ps, u1, v1, t1, q1, tref, cm, ch, ! | ||
| ! prsl1, prslki, wet, lake, xlon, sinlat, stress, ! | ||
| ! sfcemis, dlwflx, sfcnsw, rain, timestep, kdt,solhr,xcosz, ! | ||
| ! wind, flag_iter, flag_guess, nstf_name1, nstf_name4, ! | ||
| ! nstf_name5, lprnt, ipr, ! | ||
|
|
@@ -94,6 +97,7 @@ subroutine sfc_nst_run & | |
| ! prsik1 - real, im ! | ||
| ! prslk1 - real, im ! | ||
| ! wet - logical, =T if any ocn/lake water (F otherwise) im ! | ||
| ! lake - logical, =T if any lake otherwise ocn | ||
| ! icy - logical, =T if any ice im ! | ||
| ! xlon - real, longitude (radians) im ! | ||
| ! sinlat - real, sin of latitude im ! | ||
|
|
@@ -194,7 +198,8 @@ subroutine sfc_nst_run & | |
| real (kind=kind_phys), intent(in) :: timestep | ||
| real (kind=kind_phys), intent(in) :: solhr | ||
|
|
||
| logical, dimension(im), intent(in) :: flag_iter, flag_guess, wet, & | ||
| & lake | ||
| ! &, icy | ||
| logical, intent(in) :: lprnt | ||
|
|
||
|
|
@@ -259,14 +264,14 @@ subroutine sfc_nst_run & | |
| ! | ||
| do i = 1, im | ||
| ! flag(i) = wet(i) .and. .not.icy(i) .and. flag_iter(i) | ||
| flag(i) = wet(i) .and. flag_iter(i) .and. .not. lake(i) | ||
| enddo | ||
| ! | ||
| ! save nst-related prognostic fields for guess run | ||
| ! | ||
| do i=1, im | ||
| ! if(wet(i) .and. .not.icy(i) .and. flag_guess(i)) then | ||
| if(wet(i) .and. flag_guess(i) .and. .not. lake(i)) then | ||
| xt_old(i) = xt(i) | ||
| xs_old(i) = xs(i) | ||
| xu_old(i) = xu(i) | ||
|
|
@@ -582,7 +587,7 @@ subroutine sfc_nst_run & | |
| ! restore nst-related prognostic fields for guess run | ||
| do i=1, im | ||
| ! if (wet(i) .and. .not.icy(i)) then | ||
| if (wet(i) .and. .not. lake(i)) then | ||
| if (flag_guess(i)) then ! when it is guess of | ||
| xt(i) = xt_old(i) | ||
| xs(i) = xs_old(i) | ||
|
|
@@ -655,10 +660,14 @@ module sfc_nst_pre | |
| !! The NSST scheme is one of the three schemes used to represent the | ||
| !! surface in the GFS physics suite. The other two are the Noah land | ||
| !! surface model and the sice simplified ice model. | ||
| !! | ||
|
climbfuji marked this conversation as resolved.
Outdated
|
||
| !! \section arg_table_sfc_nst_init Argument Table | ||
| !! | ||
| subroutine sfc_nst_pre_init | ||
| end subroutine sfc_nst_pre_init | ||
|
|
||
| !! \section arg_table_sfc_nst_finalize Argument Table | ||
|
climbfuji marked this conversation as resolved.
Outdated
|
||
| !! | ||
| subroutine sfc_nst_pre_finalize | ||
| end subroutine sfc_nst_pre_finalize | ||
|
|
||
|
|
@@ -668,7 +677,7 @@ end subroutine sfc_nst_pre_finalize | |
| !> \section NSST_general_pre_algorithm General Algorithm | ||
| !! @{ | ||
| subroutine sfc_nst_pre_run | ||
| & (im, wet, lake, tsfc_wat, tsurf_wat, tseal, xt, xz, dt_cool, | ||
| & z_c, tref, cplflx, oceanfrac, nthreads, errmsg, errflg) | ||
|
|
||
| use machine , only : kind_phys | ||
|
|
@@ -680,7 +689,7 @@ subroutine sfc_nst_pre_run | |
|
|
||
| ! --- inputs: | ||
| integer, intent(in) :: im, nthreads | ||
| logical, dimension(im), intent(in) :: wet, lake | ||
| real (kind=kind_phys), dimension(im), intent(in) :: | ||
| & tsfc_wat, xt, xz, dt_cool, z_c, oceanfrac | ||
| logical, intent(in) :: cplflx | ||
|
|
@@ -707,7 +716,7 @@ subroutine sfc_nst_pre_run | |
| errflg = 0 | ||
|
|
||
| do i=1,im | ||
| if (wet(i) .and. .not. lake(i)) then | ||
| ! tem = (oro(i)-oro_uf(i)) * rlapse | ||
| ! DH* 20190927 simplyfing this code because tem is zero | ||
| !tem = zero | ||
|
|
@@ -722,10 +731,11 @@ subroutine sfc_nst_pre_run | |
| ! update tsfc & tref with T1 from OGCM & NSST Profile if coupled | ||
| ! | ||
| if (cplflx) then | ||
| call get_dtzm_2d (xt, xz, dt_cool, | ||
| & z_c, wet, lake, zero, omz1, im, 1, | ||
| & nthreads, dtzm) | ||
| do i=1,im | ||
| if (wet(i) .and. oceanfrac(i) > zero .and. .not. lake(i)) then | ||
| ! dnsst = tsfc_wat(i) - tref(i) ! retrive/get difference of Ts and Tf | ||
| tref(i) = tsfc_wat(i) - dtzm(i) ! update Tf with T1 and NSST T-Profile | ||
|
Collaborator
There was a problem hiding this comment. Is this safe, replacing with ? Is it guaranteed that
Contributor
There was a problem hiding this comment. I am concerned about this line too, @YihuaWu-NOAA can you explain why the original code does not work for flake model?
Contributor
There was a problem hiding this comment.
@climbfuji @junwang-noaa : tref(i) = max(tgice, tsfco(i) - dtzm(i)) needs to be used/kept. |
||
| ! tsfc_wat(i) = max(271.2,tref(i) + dnsst) ! get Ts updated due to Tf update | ||
|
|
@@ -754,11 +764,15 @@ module sfc_nst_post | |
|
|
||
| ! \defgroup GFS_NSST_POST GFS Near-Surface Sea Temperature Post | ||
| !! \brief Brief description of the parameterization | ||
| !! | ||
| !! \section arg_table_sfc_nst_post_init Argument Table | ||
|
climbfuji marked this conversation as resolved.
Outdated
|
||
| !! | ||
| subroutine sfc_nst_post_init | ||
| end subroutine sfc_nst_post_init | ||
|
|
||
| ! \brief Brief description of the subroutine | ||
| !! | ||
| !! \section arg_table_sfc_nst_post_finalize Argument Table | ||
|
climbfuji marked this conversation as resolved.
Outdated
|
||
| !! | ||
| subroutine sfc_nst_post_finalize | ||
| end subroutine sfc_nst_post_finalize | ||
|
|
@@ -773,7 +787,7 @@ end subroutine sfc_nst_post_finalize | |
| ! \section NSST_detailed_post_algorithm Detailed Algorithm | ||
| ! @{ | ||
| subroutine sfc_nst_post_run & | ||
| & ( im, rlapse, tgice, wet, lake,icy, oro, oro_uf, nstf_name1, & | ||
|
climbfuji marked this conversation as resolved.
Outdated
|
||
| & nstf_name4, nstf_name5, xt, xz, dt_cool, z_c, tref, xlon, & | ||
| & tsurf_wat, tsfc_wat, nthreads, dtzm, errmsg, errflg & | ||
| & ) | ||
|
|
@@ -787,7 +801,7 @@ subroutine sfc_nst_post_run & | |
|
|
||
| ! --- inputs: | ||
| integer, intent(in) :: im, nthreads | ||
| logical, dimension(im), intent(in) :: wet, icy, lake | ||
| real (kind=kind_phys), intent(in) :: rlapse, tgice | ||
| real (kind=kind_phys), dimension(im), intent(in) :: oro, oro_uf | ||
| integer, intent(in) :: nstf_name1, nstf_name4, nstf_name5 | ||
|
|
@@ -828,12 +842,12 @@ subroutine sfc_nst_post_run & | |
| if (nstf_name1 > 1) then | ||
| zsea1 = 0.001_kp*real(nstf_name4) | ||
| zsea2 = 0.001_kp*real(nstf_name5) | ||
| call get_dtzm_2d (xt, xz, dt_cool, z_c, wet, lake, zsea1, zsea2, & | ||
| & im, 1, nthreads, dtzm) | ||
| do i = 1, im | ||
| ! if (wet(i) .and. .not.icy(i)) then | ||
| ! if (wet(i) .and. (frac_grid .or. .not. icy(i))) then | ||
| if (wet(i) .and. .not. lake(i)) then | ||
| tsfc_wat(i) = max(tgice, tref(i) + dtzm(i)) | ||
| ! tsfc_wat(i) = max(271.2, tref(i) + dtzm(i)) - & | ||
| ! (oro(i)-oro_uf(i))*rlapse | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.