Wrapper for #588 (Updated sfc_nst.f, sfc_nst.meta, module_nst_water_prop.f90 and flake_driver.F90)

[climbfuji]

This PR builds on PR #588. It contains all of the changes in the original PR, but fixes a github issue that shows many changes to files that haven't been changed, and a few other compile errors.

Associated PRs:

#629 (contains all of #588)
NOAA-EMC/ufsatm#287
ufs-community/ufs-weather-model#532

For regression testing, see ufs-community/ufs-weather-model#532

[junwang-noaa]

@YihuaWu-NOAA the original code has "z_c_0", why is it changed to "z_c"?

[junwang-noaa]

@YihuaWu-NOAA You only need to change sbc in this file, but it seems that you rejected the updates in official repository and kept an old version. You need to keep the master code version here and the rest of the code in this file

[YihuaWu-NOAA]

Hi, Jun, I must work on an older version. What I should do is just change the logical statement (if (wet(i)) to (if (wet(i) .and. .not. use_flake). I have reverted it back. Thanks! *Yihua----------------------------------------------------Yihua Wu, Ph D*I.M. Systems Group NOAA/NWS/NCEP/EMC 5830 University Research Court, Room: 2031 College Park, Maryland 20740, USA Phone: (301)-683-3691 Fax: (301)-683-3703

…

On Fri, Apr 16, 2021 at 2:31 PM Jun Wang ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In physics/sfc_nst.f <#629 (comment)>: > @@ -724,13 +728,13 @@ subroutine sfc_nst_pre_run ! if (cplflx) then z_c_0 = 0.0 - call get_dtzm_2d (xt, xz, dt_cool, & - & z_c_0, wet, zero, omz1, im, 1, nthreads, dtzm) + call get_dtzm_2d (xt, xz, dt_cool, z_c, wet, & @YihuaWu-NOAA <https://github.com/YihuaWu-NOAA> the original code has "z_c_0", why is it changed to "z_c"? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#629 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANJBYQDERXVBXUDCQDIIMNDTJB7ALANCNFSM43B3FVGA> .

[YihuaWu-NOAA]

For this one what I need to do is just add use_flake parameter. I have reverted it back now. Thanks! *Yihua----------------------------------------------------Yihua Wu, Ph D*I.M. Systems Group NOAA/NWS/NCEP/EMC 5830 University Research Court, Room: 2031 College Park, Maryland 20740, USA Phone: (301)-683-3691 Fax: (301)-683-3703

…

On Fri, Apr 16, 2021 at 2:35 PM Jun Wang ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In physics/sfc_nst.meta <#629 (comment)>: > @@ -178,17 +178,17 @@ intent = in optional = F [cm] - standard_name = surface_drag_coefficient_for_momentum_in_air_over_water - long_name = surface exchange coeff for momentum over water + standard_name = surface_drag_coefficient_for_momentum_in_air_over_ocean @YihuaWu-NOAA <https://github.com/YihuaWu-NOAA> You only need to change sbc in this file, but it seems that you rejected the updates in official repository and kept an old version. You need to keep the master code version here and the rest of the code in this file — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#629 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANJBYQAWLBRCQDTMEM6J5YDTJB7PNANCNFSM43B3FVGA> .

[junwang-noaa]

@climbfuji Looks good to me now. Thanks for making the changes.

[climbfuji]

Original PR #588 was reviewed and approved, and testing passed. Merging this PR.