Skip to content

master: fix travis build#248

Merged
climbfuji merged 1 commit into
NCAR:masterfrom
climbfuji:fix_travis_standalone_build_20200111
Jan 24, 2020
Merged

master: fix travis build#248
climbfuji merged 1 commit into
NCAR:masterfrom
climbfuji:fix_travis_standalone_build_20200111

Conversation

@climbfuji
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji commented Jan 12, 2020

Fix travis build/testing by setting STATIC option correctly for standalone build and adding the missing new configuration option DEFAULT_BUILD_DIR to the standalone build CCPP prebuild config.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 12, 2020

Codecov Report

Merging #248 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #248   +/-   ##
=======================================
  Coverage   47.28%   47.28%           
=======================================
  Files          14       14           
  Lines        1343     1343           
=======================================
  Hits          635      635           
  Misses        708      708

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ab419e...55e861f. Read the comment docs.

@climbfuji climbfuji marked this pull request as ready for review January 12, 2020 20:35
gold2718
gold2718 approved these changes Jan 12, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay (modulo not really knowing why STATIC is incompatible with standalone build).

@climbfuji
Copy link
Copy Markdown
Collaborator Author

climbfuji commented Jan 12, 2020

Looks okay (modulo not really knowing why STATIC is incompatible with standalone build).

Thanks. The unit tests were designed for the dynamic build a while ago and are exercising explicit calls to ccpp_field_add to populate the cdata structure with pointers to the variables etc. Looking forward to Julie's and your work to create a robust testing framework for the new cap_gen.py!

grantfirl
grantfirl approved these changes Jan 23, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

This was referenced Jan 24, 2020
Merged
Merged
@climbfuji climbfuji merged commit e772109 into NCAR:master Jan 24, 2020
climbfuji added a commit to climbfuji/ccpp-framework that referenced this pull request Jan 27, 2020
@climbfuji
Merge pull request NCAR#248 from climbfuji/fix_travis_standalone_buil…
1c41a61 
…d_20200111

master: fix travis build
@climbfuji climbfuji deleted the fix_travis_standalone_build_20200111 branch June 27, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gold2718 gold2718 gold2718 approved these changes

@grantfirl grantfirl grantfirl approved these changes

@llpcarson llpcarson Awaiting requested review from llpcarson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@climbfuji @codecov-io @gold2718 @grantfirl