-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecating previewHtml #62630
Labels
api
engineering
VS Code - Build / issue tracking / etc.
verification-needed
Verification of issue is requested
verified
Verification succeeded
webview
Webview issues
Milestone
Comments
mjbvz
added
api
webview
Webview issues
engineering
VS Code - Build / issue tracking / etc.
labels
Nov 6, 2018
This was referenced Nov 6, 2018
This was referenced Nov 6, 2018
tomoki1207
added a commit
to tomoki1207/vscode-pdfviewer
that referenced
this issue
Nov 13, 2018
`vscode.previewHtml` -> `createWebviewPanel` due to microsoft/vscode#62630
nishiza
added a commit
to nishiza/superviews-preview
that referenced
this issue
Jan 31, 2019
Using the |
mjbvz
added a commit
that referenced
this issue
Feb 1, 2019
stef-levesque
added a commit
to stef-levesque/vscode-3dviewer
that referenced
this issue
Feb 5, 2019
For verification: try using the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api
engineering
VS Code - Build / issue tracking / etc.
verification-needed
Verification of issue is requested
verified
Verification succeeded
webview
Webview issues
Problem
The
vscode.previewHtml
command has been deprecated since the introduction of the webview API. The webview API is significantly easier to work with, correctly supports different filesystem setups, and webviews also offer many security benefits over htmlPreviews. For these reasons, we would like all extensions to switch over the using the webview API and eventually remove thevscode.previewHtml
command entirely.Plan
There are a number of consumers of this API currently, including many extensions that have not been updated in some time. Our goal is to:
previewHtml
.previewHtml
after the impact on end users has been minimized.Actions for November 2018:
Add notification in VS Code that alerts developers that are using
previewHtml
. This error would show up when a user is running a development version of an extension in vscode and thepreviewHtml
command is invokedOpen issues against existing users of
previewHtml
(by scanning repos of popular extensions)(Maybe) Update vscode.d.ts to treat
vscode.commands.executeCommand('vscode.previewHtml', ....)
as a compile warning / error?Longer term actions
Aggressively targeting March/April for removal. Quick sketch of deprecation process after November:
Start showing users messages if they are using an extension that uses
htmlPreview
(Jan/Feb update?)Remove the ability to call
vscode.previewHtml
for recently published extensions. (Jan / Feb update)Then remove
vscode.previewHtml
entirely. ( March / April)The text was updated successfully, but these errors were encountered: