Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to VS Code's webview API #123

Closed
mjbvz opened this issue Nov 6, 2018 · 3 comments
Closed

Upgrade to VS Code's webview API #123

mjbvz opened this issue Nov 6, 2018 · 3 comments
Assignees

Comments

@mjbvz
Copy link

mjbvz commented Nov 6, 2018

Hi, I'm on the VS Code team. I noticed that your extension uses the vscode.previewHtml command which is deprecated and which we are actively working to remove: microsoft/vscode#62630

We've developed a webview API that provides a much better developer experience and offers a number of important security and compatibility benefits over previewHtml. We cannot fix previewHtml without breaking backwards compatibility, and have instead opted to remove it.

To ensure that your extension continues to work properly in VS Code, please try upgrading to use the new Webview API. You can find documentation on the API usage here. Let me know if you have any questions or concerns about this migration

@joaompinto
Copy link
Contributor

@mjbvz thanks for letting me no, I had such change planned but I will now set it as priority.

@joaompinto
Copy link
Contributor

I am providing a preview version for the new release at https://github.com/asciidoctor/asciidoctor-vscode/releases/tag/v1.0.99. Any feedback is welcome.

@joaompinto
Copy link
Contributor

Closed with the release of v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants