-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to VS Code's webview API #1602
Comments
Thanks for the heads up! |
Just a heads up: in VS Code 1.32 (the February update), using the previewHtml command will show an alert to the user, although the command should still work. We plan to remove the command entirely with VS Code 1.33 (March update) |
I started the switch over but am having a bit of a tough go at it. Folks who use this feature with the PowerShell extension expect to be able to run their own personal JavaScript files (not under some extension's subdir). They tend to put these JS files in a workspace or their home dir. I guess I could inline the JavaScript in the HTML? |
I discovered this problem after trying to understand why this wasn't working. What's the status of this? |
@mjbvz do you have any insight on how we could accomplish running a users own personal js files (besides just inlining)? |
@wycats it is indeed broken as of 1.33 of vscode. We'll get it fixed but there might be some breaking changes that come with it as the underlying API is very different. |
@TylerLeonhardt Your webview can pass any set of paths to |
@mjbvz that sadly doesn't seem to work: The URI to my js file is there... but the function defined in said js file is not available |
Are the scripts also referenced on the page using |
Ah... wasn't also including them in the body of the html... sorry about that. Now that I've referenced them using |
There doesn't seem to be a way to update the |
The options objects are immutable but |
#1919 fixed in this. |
Hi, I'm on the VS Code team. I noticed that your extension uses the
vscode.previewHtml
command which is deprecated and which we are actively working to remove: microsoft/vscode#62630We've developed a webview API that provides a much better developer experience and offers a number of important security and compatibility benefits over
previewHtml
. We cannot fixpreviewHtml
without breaking backwards compatibility, and have instead opted to remove it.To ensure that your extension continues to work properly in VS Code, please try upgrading to use the new Webview API. You can find documentation on the API usage here. Let me know if you have any questions or concerns about this migration
The text was updated successfully, but these errors were encountered: