-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode.previewHtml depricated #17
Comments
Thanks @sarabkohli29 for reporting it and sorry for the inconvenience. Meanwhile, I'll fix this issue when I find a time. |
This is my favourite blame tool .. nothing else gives a complete file overview |
I need to do something like this change I made for my other extension. |
When I hit Annotator command, it doesn't show an error popup dialog, it just gets logged on the dev-tool console as @sarabkohli29 kindly posted the screenshot... If there's no error popup, it's confusing :( |
Does WebView panel not support <a href="command:annotator.takeDiff?%5B%7B...">12 2018-12-24 Ryuichi Inagaki</a> |
Wow, it's coming together. Seems like you already got most of the things. Thank you for fixing this. I was about try my first open source PR to make those changes, but since I am new to this, I wasn't able to fully grasp the API. Seems you've figured out all the things needed. Just to mention, webview api should be able to support HTML, so the |
Hi @sarabkohli29 ! Wow, I didn't know that you were considering to fix this, thank you 😊 I've already started this one, but if there are other things, your help is much appreciated! Re webview panel, yes, that's what I thought too. I played with |
Oops, my bad! It's actually I just have to pass https://code.visualstudio.com/api/references/vscode-api#WebviewOptions |
Thank you @sarabkohli29 and @timwaddell for reporting this! and sorry for the inconvenience caused! The fix is released as v0.11.1 🎉 |
Actually, thank you @ryu1kn for fixing this! :) |
This reverts commit ea79f28. Use WebView's postMessage to send control back to extension
thank you :) |
While trying to open annotater from the vscode command prompt on vscode Version 1.33.0 (1.33.0), the annotater is not able to open the diff file and ends upthrowing a console error
Reading the vscode docs, it mentions that the vscode.previewHtml has been completely been depricated here microsoft/vscode#62630 in the March/April release and instead the webview api should be used. https://code.visualstudio.com/api/extension-guides/webview
I am on MacOS Mojave version 10.14.4 MBP-15 2018 version
The text was updated successfully, but these errors were encountered: