Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to VS Code's webview API #403

Closed
mjbvz opened this issue Nov 6, 2018 · 6 comments
Closed

Upgrade to VS Code's webview API #403

mjbvz opened this issue Nov 6, 2018 · 6 comments

Comments

@mjbvz
Copy link

mjbvz commented Nov 6, 2018

Hi, I'm on the VS Code team. I noticed that your extension uses the vscode.previewHtml command which is deprecated and which we are actively working to remove: microsoft/vscode#62630

We've developed a webview API that provides a much better developer experience and offers a number of important security and compatibility benefits over previewHtml. We cannot fix previewHtml without breaking backwards compatibility, and have instead opted to remove it.

To ensure that your extension continues to work properly in VS Code, please try upgrading to use the new Webview API. You can find documentation on the API usage here. Let me know if you have any questions or concerns about this migration

@nasreddineskandrani
Copy link

nasreddineskandrani commented Nov 27, 2018

where is the owner of this repo :) @seanpoulter
Can you please open a gitter and maybe add some official collaborators to help you with the repo.
Thanks (20days idle some companies will collapse - joke)

@seanpoulter
Copy link
Member

Thanks for the heads up @mjbvz.

What do you have in mind for Gitter @nasreddineskandrani? If you're joking that you rely on this extension for your business, I'm happy to help review your PR.

@nasreddineskandrani
Copy link

nasreddineskandrani commented Nov 27, 2018

A gitter channel:
People can ask live question. For example the overlay for the coverage is not working. It's more easy to live chat about this kind of issues. Maybe some devs have an old version where it's working or maybe it's due to a new version of vscode and some people can tell us which version is fine etc...
since it's free why not? some great lib use gitter as angular or ngrx!

Collaborators:
you can nominate if you have someone active to answer issue as collaborator in your github repo (ifnot done yet). Which lower the load on the main members of the project and let the collaborator answer question in gitter and github issues from time to time.

the joke was to attract your attention since i found this post important. I thought maybe you ll filter in email your github messages :)

( nice work with this extension, i like it)

@seanpoulter
Copy link
Member

Thanks for the suggestion to use Gitter. I've opened #407 to see who's interested and if they can pay attention to a Gitter channel. It sounds like it could help but I'm worried it'll take our time away from all these Issues and PRs. 😉

Any thoughts on what we need to fix for the webview API?

@mjbvz
Copy link
Author

mjbvz commented Feb 1, 2019

Just a heads up: in VS Code 1.32 (the February update), using the previewHtml command will show an alert to the user, although the command should still work. We plan to remove the command entirely with VS Code 1.33 (March update)

@dons20
Copy link

dons20 commented Mar 20, 2019

The March update is probably coming soon, any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants