[codex] Stabilize skippy smoke chain startup - #849
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis script update makes dense chain smoke test configuration more flexible by replacing hardcoded defaults with optional environment-driven values. Dense split boundaries now compute automatically if not explicitly set, and startup timeout becomes configurable instead of hardcoded to 60 seconds. ChangesDense Chain Smoke Test Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
i386
marked this pull request as draft
June 13, 2026 10:18
i386
marked this pull request as ready for review
June 13, 2026 10:39
Collaborator
|
Interesting wonder why it has to be flexible with this now |
michaelneale
added a commit
that referenced
this pull request
Jun 14, 2026
* origin/main: Add bounded direct path repair (#846) Fix skippy smoke PR gate (#850) Stabilize skippy smoke chain startup (#849) # Conflicts: # crates/mesh-llm-host-runtime/src/mesh/direct_path.rs # crates/mesh-llm-host-runtime/src/mesh/mod.rs # crates/mesh-llm-host-runtime/src/protocol/mod.rs # crates/mesh-llm-protocol/src/protocol/mod.rs
michaelneale
added a commit
that referenced
this pull request
Jun 14, 2026
* origin/main: (29 commits) MoA: don't let small-model consensus pre-empt a still-running large model (#837) fix(console): render thinking traces as markdown Add bounded direct path repair (#846) Fix skippy smoke PR gate (#850) Stabilize skippy smoke chain startup (#849) fix(ci): switch back to auto-assign workflow fix(website): polish longform visual explainer (#843) fix: gemma thinking Carry GLM llama MTP patches (#840) Refresh llama.cpp canary patch queue (#839) Add transport-aware Skippy stage ordering (#814) Share Skippy stage wire byte accounting (#818) Report Skippy artifact cold-start costs (#815) fix: debug output capturing for TUI / panics (#827) fix(hero): visual corrections for iPhone SE size devices (#838) Add Skippy stage role metadata (#816) Add Skippy request cache epoch telemetry (#817) Consolidate agent skills and fix stale docs (Windows deploy, repo map, design docs) (#836) feature(version): normalize version markers for different build types (#831) fix(website): fix visual regressions (#835) ... # Conflicts: # AGENTS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stabilizes the PR
Linux tests (skippy-smoke)lane by balancing the dense 3-stage smoke split and making dense chain startup timeout configurable.Why
Several unrelated PRs have failed with
stage 2 binary server did not become ready. The old default dense split1,2leaves stage 2 owning nearly the full 30-layer smoke model, so startup can exceed the fixed 60s readiness timeout on current GitHub runners.Details
DENSE_SMOKE_SPLIT_1/DENSE_SMOKE_SPLIT_2override support intact.DENSE_CHAIN_STARTUP_TIMEOUT_SECS, defaulting to180, and passes it toskippy-correctness chain.Validation
bash -n scripts/skippy-ci-smoke.shgit diff --checkSummary by CodeRabbit