Skip to content

[codex] Stabilize skippy smoke chain startup - #849

Merged
i386 merged 1 commit into
mainfrom
codex/skippy-smoke-balanced-splits
Jun 13, 2026
Merged

[codex] Stabilize skippy smoke chain startup#849
i386 merged 1 commit into
mainfrom
codex/skippy-smoke-balanced-splits

Conversation

@i386

@i386 i386 commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

Stabilizes the PR Linux tests (skippy-smoke) lane by balancing the dense 3-stage smoke split and making dense chain startup timeout configurable.

Why

Several unrelated PRs have failed with stage 2 binary server did not become ready. The old default dense split 1,2 leaves stage 2 owning nearly the full 30-layer smoke model, so startup can exceed the fixed 60s readiness timeout on current GitHub runners.

Details

  • Leaves DENSE_SMOKE_SPLIT_1 / DENSE_SMOKE_SPLIT_2 override support intact.
  • When unset, computes roughly one-third/two-third balanced splits from the inspected dense layer count.
  • Adds DENSE_CHAIN_STARTUP_TIMEOUT_SECS, defaulting to 180, and passes it to skippy-correctness chain.

Validation

  • bash -n scripts/skippy-ci-smoke.sh
  • git diff --check

Summary by CodeRabbit

  • Chores
    • Enhanced smoke testing infrastructure with flexible split boundary configuration that no longer enforces default values
    • Introduced configurable startup timeout for chain operations, replacing hardcoded value (default: 180 seconds)

@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a8ae9425-b23b-4288-a40c-417b5416fb86

📥 Commits

Reviewing files that changed from the base of the PR and between 39cd7d2 and 9bd68ca.

📒 Files selected for processing (1)
  • scripts/skippy-ci-smoke.sh

📝 Walkthrough

Walkthrough

This script update makes dense chain smoke test configuration more flexible by replacing hardcoded defaults with optional environment-driven values. Dense split boundaries now compute automatically if not explicitly set, and startup timeout becomes configurable instead of hardcoded to 60 seconds.

Changes

Dense Chain Smoke Test Configuration

Layer / File(s) Summary
Dense split boundary configuration and selection logic
scripts/skippy-ci-smoke.sh
DENSE_SMOKE_SPLIT_1 and DENSE_SMOKE_SPLIT_2 default to unset, triggering conditional logic: explicit values are used directly if both are provided; otherwise balanced split points are computed from DENSE_LAYER_END with validation clamping.
Startup timeout configuration usage
scripts/skippy-ci-smoke.sh
New DENSE_CHAIN_STARTUP_TIMEOUT_SECS variable (default 180) replaces the hardcoded 60-second timeout in the dense chain correctness invocation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: configuring dense chain startup to stabilize CI smoke tests by balancing splits and making timeout configurable.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/skippy-smoke-balanced-splits

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
github-actions Bot requested a review from michaelneale June 13, 2026 10:18
@i386
i386 marked this pull request as draft June 13, 2026 10:18
@i386
i386 marked this pull request as ready for review June 13, 2026 10:39
@github-actions
github-actions Bot requested a review from ndizazzo June 13, 2026 10:39
@michaelneale

Copy link
Copy Markdown
Collaborator

Interesting wonder why it has to be flexible with this now

@i386
i386 merged commit 625ce18 into main Jun 13, 2026
52 of 65 checks passed
@i386
i386 deleted the codex/skippy-smoke-balanced-splits branch June 13, 2026 10:56
michaelneale added a commit that referenced this pull request Jun 14, 2026
* origin/main:
  Add bounded direct path repair (#846)
  Fix skippy smoke PR gate (#850)
  Stabilize skippy smoke chain startup (#849)

# Conflicts:
#	crates/mesh-llm-host-runtime/src/mesh/direct_path.rs
#	crates/mesh-llm-host-runtime/src/mesh/mod.rs
#	crates/mesh-llm-host-runtime/src/protocol/mod.rs
#	crates/mesh-llm-protocol/src/protocol/mod.rs
michaelneale added a commit that referenced this pull request Jun 14, 2026
* origin/main: (29 commits)
  MoA: don't let small-model consensus pre-empt a still-running large model (#837)
  fix(console): render thinking traces as markdown
  Add bounded direct path repair (#846)
  Fix skippy smoke PR gate (#850)
  Stabilize skippy smoke chain startup (#849)
  fix(ci): switch back to auto-assign workflow
  fix(website): polish longform visual explainer (#843)
  fix: gemma thinking
  Carry GLM llama MTP patches (#840)
  Refresh llama.cpp canary patch queue (#839)
  Add transport-aware Skippy stage ordering (#814)
  Share Skippy stage wire byte accounting (#818)
  Report Skippy artifact cold-start costs (#815)
  fix: debug output capturing for TUI / panics (#827)
  fix(hero): visual corrections for iPhone SE size devices (#838)
  Add Skippy stage role metadata (#816)
  Add Skippy request cache epoch telemetry (#817)
  Consolidate agent skills and fix stale docs (Windows deploy, repo map, design docs) (#836)
  feature(version): normalize version markers for different build types (#831)
  fix(website): fix visual regressions (#835)
  ...

# Conflicts:
#	AGENTS.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants