fix(website): fix visual regressions - #835
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughRefines stage-2 hero visuals: adds aperture opening timing and desktop scroll mapping, syncs top chrome height into CSS variables, toggles an aperture-active body class, shifts mesh-grid SVG alignment, and refactors CSS backgrounds to use new aperture/grid variables. ChangesStage-2 Aperture Animation System
Sequence DiagramsequenceDiagram
participant Scroll
participant ModelSlicing
participant Document as Document/CSS
participant HeroViz as hero-viz
Scroll->>ModelSlicing: produce scrollProgress
ModelSlicing->>ModelSlicing: compute stageProgress (desktop-aware mapping)
ModelSlicing->>Document: set CSS vars (--stage2-*) via syncHeroChromeMetrics()
ModelSlicing->>Document: toggle body class is-stage2-aperture-active
ModelSlicing->>HeroViz: drive visual timing (aperture/mesh zoom)
HeroViz->>HeroViz: set SVG `#mesh-grid` patternTransform (translate 18 18)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@website/src/assets/site.css`:
- Line 4971: Add the required blank line before the CSS declaration 'content:
"";' in the updated aperture/grid rule blocks to satisfy stylelint's
declaration-empty-line-before; locate the 'content: "";' declarations (used
inside the aperture/grid selector blocks) and insert a single empty line
immediately above each 'content' line so the declaration is preceded by a blank
line as required by the linter.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 5cdb083b-11b8-43f0-b52e-0213944b2689
📒 Files selected for processing (3)
website/src/assets/hero-viz.jswebsite/src/assets/model-slicing.jswebsite/src/assets/site.css
* origin/main: Add transport-aware Skippy stage ordering (#814) Share Skippy stage wire byte accounting (#818) Report Skippy artifact cold-start costs (#815) fix: debug output capturing for TUI / panics (#827) fix(hero): visual corrections for iPhone SE size devices (#838) Add Skippy stage role metadata (#816) Add Skippy request cache epoch telemetry (#817) Consolidate agent skills and fix stale docs (Windows deploy, repo map, design docs) (#836) feature(version): normalize version markers for different build types (#831) fix(website): fix visual regressions (#835) fix(gh): change micn to michaelneale in auto_assign.yml Revert "fix(gh): replace micn with IvGolovach in auto_assign.yml (not a collaborator)" fix(gh): replace micn with IvGolovach in auto_assign.yml (not a collaborator)
* origin/main: (29 commits) MoA: don't let small-model consensus pre-empt a still-running large model (#837) fix(console): render thinking traces as markdown Add bounded direct path repair (#846) Fix skippy smoke PR gate (#850) Stabilize skippy smoke chain startup (#849) fix(ci): switch back to auto-assign workflow fix(website): polish longform visual explainer (#843) fix: gemma thinking Carry GLM llama MTP patches (#840) Refresh llama.cpp canary patch queue (#839) Add transport-aware Skippy stage ordering (#814) Share Skippy stage wire byte accounting (#818) Report Skippy artifact cold-start costs (#815) fix: debug output capturing for TUI / panics (#827) fix(hero): visual corrections for iPhone SE size devices (#838) Add Skippy stage role metadata (#816) Add Skippy request cache epoch telemetry (#817) Consolidate agent skills and fix stale docs (Windows deploy, repo map, design docs) (#836) feature(version): normalize version markers for different build types (#831) fix(website): fix visual regressions (#835) ... # Conflicts: # AGENTS.md
There was a white line in the middle of the site after recent changes
tweaks the opening aperture start so it's not so long
fixed the nav appearing the middle of the white screen mode white the split is being demonstrated
Summary by CodeRabbit