Skip to content

fix(website): fix visual regressions - #835

Merged
ndizazzo merged 2 commits into
mainfrom
fix/landing-aperture-line-regression
Jun 12, 2026
Merged

fix(website): fix visual regressions#835
ndizazzo merged 2 commits into
mainfrom
fix/landing-aperture-line-regression

Conversation

@ndizazzo

@ndizazzo ndizazzo commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

There was a white line in the middle of the site after recent changes
tweaks the opening aperture start so it's not so long
fixed the nav appearing the middle of the white screen mode white the split is being demonstrated

Summary by CodeRabbit

  • Style
    • Adjusted hero mesh grid positioning for a cleaner background alignment
    • Refined navigation transitions with reduced-motion support for smoother/accessible behavior
    • Polished aperture, overlay and mesh-zoom visuals for stage‑2 hero/workspace
  • New Features
    • Improved desktop vs. touch scroll timing for aperture entry and stage progress
    • Header geometry is now synced to layout so overlays and animations align more reliably

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 87fb7169-ab92-431b-b214-e30e4d7e391e

📥 Commits

Reviewing files that changed from the base of the PR and between cfda627 and 8f172a7.

📒 Files selected for processing (1)
  • website/src/assets/site.css
🚧 Files skipped from review as they are similar to previous changes (1)
  • website/src/assets/site.css

📝 Walkthrough

Walkthrough

Refines stage-2 hero visuals: adds aperture opening timing and desktop scroll mapping, syncs top chrome height into CSS variables, toggles an aperture-active body class, shifts mesh-grid SVG alignment, and refactors CSS backgrounds to use new aperture/grid variables.

Changes

Stage-2 Aperture Animation System

Layer / File(s) Summary
Aperture timing and desktop scroll mapping
website/src/assets/model-slicing.js
Adds APERTURE_OPEN_START, APERTURE_OPEN_END, and DESKTOP_APERTURE_ENTRY_SCROLL_FACTOR. Replaces linear scroll↔stage progress conversion with desktop-aware conditional mapping when useTouchScrollProfile() is false.
Chrome metrics synchronization
website/src/assets/model-slicing.js
Introduces syncHeroChromeMetrics() to measure navigation chrome height and write pixel CSS variables. Calls added in init() and handleGeometryChange() to keep metrics current.
Aperture visual timing and active state
website/src/assets/model-slicing.js, website/src/assets/hero-viz.js
Applies APERTURE_OPEN_START/APERTURE_OPEN_END to aperture fade-in and mesh zoom timing. Toggles is-stage2-aperture-active body class in non-reduced-motion flows. Adjusts SVG #mesh-grid patternTransform to translate by 18 18.
Navigation behavior and transitions
website/src/assets/model-slicing.js, website/src/assets/site.css
Nav return logic now uses a threshold (stageProgress >= SCRUBBER_END) instead of eased aperture-close. nav.top transition now explicitly animates opacity and transform with will-change, and is disabled under prefers-reduced-motion.
CSS variable refactoring for aperture and grid styling
website/src/assets/site.css
Replaces inline gradients with --stage2-aperture-* and --stage2-hero-grid-*-pos variables and composes radial and grid background layers from those variables, including active-state (--stage2-aperture-active-*) positioning.

Sequence Diagram

sequenceDiagram
  participant Scroll
  participant ModelSlicing
  participant Document as Document/CSS
  participant HeroViz as hero-viz

  Scroll->>ModelSlicing: produce scrollProgress
  ModelSlicing->>ModelSlicing: compute stageProgress (desktop-aware mapping)
  ModelSlicing->>Document: set CSS vars (--stage2-*) via syncHeroChromeMetrics()
  ModelSlicing->>Document: toggle body class is-stage2-aperture-active
  ModelSlicing->>HeroViz: drive visual timing (aperture/mesh zoom)
  HeroViz->>HeroViz: set SVG `#mesh-grid` patternTransform (translate 18 18)
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'fix(website): fix visual regressions' accurately describes the main purpose of the changeset, which addresses visual issues including a white line regression and navigation visibility problems during the stage-2 aperture animation.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/landing-aperture-line-regression

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@website/src/assets/site.css`:
- Line 4971: Add the required blank line before the CSS declaration 'content:
"";' in the updated aperture/grid rule blocks to satisfy stylelint's
declaration-empty-line-before; locate the 'content: "";' declarations (used
inside the aperture/grid selector blocks) and insert a single empty line
immediately above each 'content' line so the declaration is preceded by a blank
line as required by the linter.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5cdb083b-11b8-43f0-b52e-0213944b2689

📥 Commits

Reviewing files that changed from the base of the PR and between f25aa0d and cfda627.

📒 Files selected for processing (3)
  • website/src/assets/hero-viz.js
  • website/src/assets/model-slicing.js
  • website/src/assets/site.css

Comment thread website/src/assets/site.css
@ndizazzo
ndizazzo merged commit 0210b10 into main Jun 12, 2026
21 checks passed
@ndizazzo
ndizazzo deleted the fix/landing-aperture-line-regression branch June 12, 2026 08:19
michaelneale added a commit that referenced this pull request Jun 13, 2026
* origin/main:
  Add transport-aware Skippy stage ordering (#814)
  Share Skippy stage wire byte accounting (#818)
  Report Skippy artifact cold-start costs (#815)
  fix: debug output capturing for TUI / panics (#827)
  fix(hero): visual corrections for iPhone SE size devices (#838)
  Add Skippy stage role metadata (#816)
  Add Skippy request cache epoch telemetry (#817)
  Consolidate agent skills and fix stale docs (Windows deploy, repo map, design docs) (#836)
  feature(version): normalize version markers for different build types (#831)
  fix(website): fix visual regressions (#835)
  fix(gh): change micn to michaelneale in auto_assign.yml
  Revert "fix(gh): replace micn with IvGolovach in auto_assign.yml (not a collaborator)"
  fix(gh): replace micn with IvGolovach in auto_assign.yml (not a collaborator)
michaelneale added a commit that referenced this pull request Jun 14, 2026
* origin/main: (29 commits)
  MoA: don't let small-model consensus pre-empt a still-running large model (#837)
  fix(console): render thinking traces as markdown
  Add bounded direct path repair (#846)
  Fix skippy smoke PR gate (#850)
  Stabilize skippy smoke chain startup (#849)
  fix(ci): switch back to auto-assign workflow
  fix(website): polish longform visual explainer (#843)
  fix: gemma thinking
  Carry GLM llama MTP patches (#840)
  Refresh llama.cpp canary patch queue (#839)
  Add transport-aware Skippy stage ordering (#814)
  Share Skippy stage wire byte accounting (#818)
  Report Skippy artifact cold-start costs (#815)
  fix: debug output capturing for TUI / panics (#827)
  fix(hero): visual corrections for iPhone SE size devices (#838)
  Add Skippy stage role metadata (#816)
  Add Skippy request cache epoch telemetry (#817)
  Consolidate agent skills and fix stale docs (Windows deploy, repo map, design docs) (#836)
  feature(version): normalize version markers for different build types (#831)
  fix(website): fix visual regressions (#835)
  ...

# Conflicts:
#	AGENTS.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant