Skip to content

fix(hero): visual corrections for iPhone SE size devices - #838

Merged
i386 merged 1 commit into
mainfrom
fix/website-iphone-se-hero
Jun 13, 2026
Merged

fix(hero): visual corrections for iPhone SE size devices#838
i386 merged 1 commit into
mainfrom
fix/website-iphone-se-hero

Conversation

@ndizazzo

@ndizazzo ndizazzo commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

This changes website/src/assets/hero-viz.js: on short portrait phones with window.innerWidth <= 390 and stage height below about 660px, it reserves an extra 14-20px above the hero footer and uses the actual heading/subtitle text bounds when positioning the hero title.

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Improved title positioning calculations for different screen sizes and device orientations, particularly on mobile devices with varying footer spacing and viewport widths.

@ndizazzo ndizazzo self-assigned this Jun 12, 2026
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ef8ca351-bcd5-4b69-82b3-74353a1ae59b

📥 Commits

Reviewing files that changed from the base of the PR and between 226d1c6 and a78b8d7.

📒 Files selected for processing (1)
  • website/src/assets/hero-viz.js

📝 Walkthrough

Walkthrough

Hero title positioning is improved with new measurement-based helpers. titleTextRect() computes bounding boxes from title/subtitle DOM elements. shortPhoneTitleFooterReserve() calculates an extra layout reserve for short phones. The positionTitle() function is refactored to use these helpers when deriving title height and adjusting maximum vertical position constraints.

Changes

Hero Title Positioning

Layer / File(s) Summary
Measurement and reserve helpers
website/src/assets/hero-viz.js
titleTextRect() merges title heading and subtitle bounding boxes. shortPhoneTitleFooterReserve() computes extra top-position reserve for short-phone viewport conditions.
positionTitle integration
website/src/assets/hero-viz.js
positionTitle() function now declares titleRect and titleFooterReserve variables, measures title height from the new helper, and updates maxTop calculation to include the computed reserve.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: visual corrections for iPhone SE size devices, which matches the PR objective of fixing hero positioning on short portrait phones.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/website-iphone-se-hero

Comment @coderabbitai help to get the list of available commands and usage tips.

@i386
i386 merged commit 198a1e1 into main Jun 13, 2026
21 checks passed
@i386
i386 deleted the fix/website-iphone-se-hero branch June 13, 2026 02:47
michaelneale added a commit that referenced this pull request Jun 13, 2026
* origin/main:
  Add transport-aware Skippy stage ordering (#814)
  Share Skippy stage wire byte accounting (#818)
  Report Skippy artifact cold-start costs (#815)
  fix: debug output capturing for TUI / panics (#827)
  fix(hero): visual corrections for iPhone SE size devices (#838)
  Add Skippy stage role metadata (#816)
  Add Skippy request cache epoch telemetry (#817)
  Consolidate agent skills and fix stale docs (Windows deploy, repo map, design docs) (#836)
  feature(version): normalize version markers for different build types (#831)
  fix(website): fix visual regressions (#835)
  fix(gh): change micn to michaelneale in auto_assign.yml
  Revert "fix(gh): replace micn with IvGolovach in auto_assign.yml (not a collaborator)"
  fix(gh): replace micn with IvGolovach in auto_assign.yml (not a collaborator)
michaelneale added a commit that referenced this pull request Jun 14, 2026
* origin/main: (29 commits)
  MoA: don't let small-model consensus pre-empt a still-running large model (#837)
  fix(console): render thinking traces as markdown
  Add bounded direct path repair (#846)
  Fix skippy smoke PR gate (#850)
  Stabilize skippy smoke chain startup (#849)
  fix(ci): switch back to auto-assign workflow
  fix(website): polish longform visual explainer (#843)
  fix: gemma thinking
  Carry GLM llama MTP patches (#840)
  Refresh llama.cpp canary patch queue (#839)
  Add transport-aware Skippy stage ordering (#814)
  Share Skippy stage wire byte accounting (#818)
  Report Skippy artifact cold-start costs (#815)
  fix: debug output capturing for TUI / panics (#827)
  fix(hero): visual corrections for iPhone SE size devices (#838)
  Add Skippy stage role metadata (#816)
  Add Skippy request cache epoch telemetry (#817)
  Consolidate agent skills and fix stale docs (Windows deploy, repo map, design docs) (#836)
  feature(version): normalize version markers for different build types (#831)
  fix(website): fix visual regressions (#835)
  ...

# Conflicts:
#	AGENTS.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants