Consolidate agent skills and fix stale docs (Windows deploy, repo map, design docs) - #836
Conversation
…rect design docs AGENTS.md repo map updates: - Remove phantom docs (MoE_PLAN, MoE_DEPLOY_DESIGN, LLAMA_CPP_FORK, docs/moe/) and phantom crates (mesh-api, mesh-api-ffi, mesh-host-core) from the map - Document the real CLI split: mesh-llm-cli (Clap), mesh-llm-commands (handlers), crates/mesh-llm/src/commands/ (dispatch); the host-runtime src/cli/ directory referenced by three rules no longer exists - Expand the workspace crate list to cover the ~20 unlisted crates, grouped by responsibility - Fix 'just clean-ui' -> 'just ui-clean' (also in mesh-llm-ui AGENTS.md), version bump location (workspace Cargo.toml), and in-tree plugin list (only blobstore remains; others are external plugins) - Release flow now documents the workflow_dispatch path as primary RELEASE.md: lead with the GitHub Actions dispatch path. New .skills/deploy-windows skill covering install.ps1 (irm | iex), flavor selection, the PR #828 PowerShell 5.1 gotchas, contrib/windows helpers, and verification; cross-linked from the other deploy skills. Design doc corrections (stale-as-fact content only): - DESIGN.md: architecture tree updated to the host-runtime module layout (no src/cli/, no rewrite.rs); NodeRole comments, stream table, bootstrap proxy, and B2B transfer sections no longer claim external llama-server/rpc-server processes - METRICS.md: /api/runtime/llama producer is the embedded runtime's lane status, not an external llama-server /metrics+/slots poller - message_protocol.md: add missing 0x0a PLUGIN_MESH_STREAM and 0x0d SUBPROTOCOL rows to the stream table - VIRTUAL_LLM.md, MODEL_ROUTER.md, LLAMA_STAGE_INTEGRATION_PLAN.md: add status framing so historical llama-server-era content reads as historical, with pointers to the current implementation paths
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis pull request restructures documentation across the mesh-llm repository. It introduces a new ChangesDocumentation Restructure for Skills Framework and Architecture
🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/design/DESIGN.md (1)
21-21: 💤 Low valueAdd language specifier to fenced code block.
The code block at line 21 lacks a language tag, triggering markdownlint MD040. Add
textorshto the opening fence.🔧 Proposed fix
-``` +```text crates/mesh-llm-host-runtime/src/🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/DESIGN.md` at line 21, The fenced code block opening fence at the reported location is missing a language specifier (causing markdownlint MD040); update the opening triple-backtick to include a language like `text` or `sh` so the block becomes a fenced block with a language tag (e.g., change the opening fence for the snippet that contains "crates/mesh-llm-host-runtime/src/" to use ```text or ```sh).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docs/design/DESIGN.md`:
- Line 21: The fenced code block opening fence at the reported location is
missing a language specifier (causing markdownlint MD040); update the opening
triple-backtick to include a language like `text` or `sh` so the block becomes a
fenced block with a language tag (e.g., change the opening fence for the snippet
that contains "crates/mesh-llm-host-runtime/src/" to use ```text or ```sh).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 2cddb0d7-d3c2-47d9-9921-f755d770fea9
📒 Files selected for processing (16)
.skills/README.md.skills/connect-agents/SKILL.md.skills/deploy-linux-gpu/SKILL.md.skills/deploy-macos/SKILL.md.skills/deploy-windows/SKILL.md.skills/deploy/SKILL.md.skills/mesh-join/SKILL.mdAGENTS.mdRELEASE.mdcrates/mesh-llm-ui/AGENTS.mddocs/design/DESIGN.mddocs/design/LLAMA_STAGE_INTEGRATION_PLAN.mddocs/design/METRICS.mddocs/design/MODEL_ROUTER.mddocs/design/VIRTUAL_LLM.mddocs/design/message_protocol.md
💤 Files with no reviewable changes (1)
- .skills/deploy/SKILL.md
* origin/main: Add transport-aware Skippy stage ordering (#814) Share Skippy stage wire byte accounting (#818) Report Skippy artifact cold-start costs (#815) fix: debug output capturing for TUI / panics (#827) fix(hero): visual corrections for iPhone SE size devices (#838) Add Skippy stage role metadata (#816) Add Skippy request cache epoch telemetry (#817) Consolidate agent skills and fix stale docs (Windows deploy, repo map, design docs) (#836) feature(version): normalize version markers for different build types (#831) fix(website): fix visual regressions (#835) fix(gh): change micn to michaelneale in auto_assign.yml Revert "fix(gh): replace micn with IvGolovach in auto_assign.yml (not a collaborator)" fix(gh): replace micn with IvGolovach in auto_assign.yml (not a collaborator)
* origin/main: (29 commits) MoA: don't let small-model consensus pre-empt a still-running large model (#837) fix(console): render thinking traces as markdown Add bounded direct path repair (#846) Fix skippy smoke PR gate (#850) Stabilize skippy smoke chain startup (#849) fix(ci): switch back to auto-assign workflow fix(website): polish longform visual explainer (#843) fix: gemma thinking Carry GLM llama MTP patches (#840) Refresh llama.cpp canary patch queue (#839) Add transport-aware Skippy stage ordering (#814) Share Skippy stage wire byte accounting (#818) Report Skippy artifact cold-start costs (#815) fix: debug output capturing for TUI / panics (#827) fix(hero): visual corrections for iPhone SE size devices (#838) Add Skippy stage role metadata (#816) Add Skippy request cache epoch telemetry (#817) Consolidate agent skills and fix stale docs (Windows deploy, repo map, design docs) (#836) feature(version): normalize version markers for different build types (#831) fix(website): fix visual regressions (#835) ... # Conflicts: # AGENTS.md
Agents (and humans) working in this repo now get accurate, consolidated how-to skills for every platform, a repo map that matches the actual workspace, and design docs that no longer describe the retired external llama-server/rpc-server world as current fact.
Skills consolidation (
.skills/)deploy-macos(rewritten, renamed fromdeploy) — the old skill described the pre-embedded-runtime world:rpc-server/llama-server/.dylibbundles,~/.models/storage, manual GGUF pre-download. Rewritten for the single-binary embedded runtime: release install (incl.--servicelaunchd), dev-bundle deploy with codesign/xattr quarantine fix, verification, troubleshooting.deploy-windows(new) — captures the install.ps1 work from Fix Windows install on PowerShell 5.1 (irm | iex and missing checksum sidecar) #828:irm | iexflow, flavor selection (cuda-blackwell/cuda/rocm/vulkan/cpu), the PowerShell 5.1[ValidateSet]-under-iexand response-less-WebException checksum gotchas,contrib/windowshelpers,curl.exevs the IWR alias, verification, troubleshooting.mesh-join(new) — creating/joining/publishing meshes: invite-token flow,--auto/public mesh, named meshes, mDNS LAN mode, NAT/--bind-ip/--bind-port/Docker-bridge gotchas, multi-node verification.connect-agents(new) — pointing Goose/Claude Code/OpenCode/Pi or any OpenAI client at a mesh: built-in launchers,autovsmeshvs exact model ids, QA probes, blackboard + MCP.deploy-linux-gpu— cross-links to the sibling skills, systemd--serviceinstall path added..skills/README.md(new) — index plus the shared ground rules (single binary, never pre-download models,--headless≠ quiet, prefermesh-llm stop) so conflicting instructions can't silently reappear.Repo map and process docs
MoE_PLAN,MoE_DEPLOY_DESIGN,LLAMA_CPP_FORK,docs/moe/) and phantom crates (mesh-api,mesh-api-ffi,mesh-host-core); documented the real CLI split (mesh-llm-cli/mesh-llm-commands/crates/mesh-llm/src/commands/— the host-runtimesrc/cli/directory referenced by three placement rules no longer exists); expanded the crate list to cover ~20 unlisted crates; fixedjust clean-ui→just ui-clean, the version-bump location (workspaceCargo.toml), the in-tree plugin list (onlyblobstoreremains in-tree), and the deploy snippet ("three binaries" → single binary).workflow_dispatchwith version input,skip_gpu_bundles/canaryoptions). The previously documentedjust release v0.X.Yrecipe does not exist.Design doc corrections
Only stale-as-fact content was changed; future-looking proposals were left alone, and historical content got explicit status framing instead of rewrites:
mesh-llm-host-runtimemodule layout (nosrc/cli/, nonetwork/rewrite.rs);NodeRolecomments, the QUIC stream table, bootstrap proxy, and B2B transfer sections no longer claim externalllama-server/rpc-serverprocesses./api/runtime/llamaproducer flow corrected: snapshots come from the embedded runtime's lane status (LocalRuntimeModelHandle::llama_slots_snapshot), not an external llama-server/metrics+/slotspoller.0x0a PLUGIN_MESH_STREAMand0x0d SUBPROTOCOLrows to the stream-type table (both already documented in prose / implemented inprotocol/mod.rs).inference/skippy/hooks.rs,skippy-serverbefore-chat hooks) and marking thellama-patches/+sync.shco-iteration setup as gone.network/router.rs) with a pointer toROUTER_V2.md.Validation
crates/mesh-llm-host-runtime/src/protocol/mod.rs; metrics producer flow traced throughruntime/local.rs→runtime_data/producers.rs; release flow checked against.github/workflows/release.yml.install.ps1, commit cb3a818 (Fix Windows install on PowerShell 5.1 (irm | iex and missing checksum sidecar) #828), andcontrib/windows/.GIT_MASTER=1 git diff --checkclean. Docs/skills-only change — no code paths touched.Summary by CodeRabbit
.skills/README.mdoverview and mapping of repo skills