docs(audit): consolidate the three independent v3.8.55 reviews - #74
Merged
Merged
Conversation
Three auditors ran in parallel — architecture, offensive security, and product/QA — each in its own worktree, without access to the others' conclusions, and each required to re-verify every finding against the current tip before reporting. The tree advanced under them (#53, #56, #64, #65, #66 merged mid-audit) and all three confirmed by diff which of their findings survived. Verdicts: A 0/1, B 1/1, C 0/1 (CRITICAL/HIGH). The CRITICAL is the one that matters for a published instance: the whole /v1/** surface answered anonymous internet callers, because requireLogin governs /api/** and /v1/** is governed by REQUIRE_API_KEY, which ships false — and the VM deployment guide prescribed exactly that. Fixed in #69. The section records that my own 3.8.54 smoke test missed it by probing the wrong surface. Also recorded, rather than summarised away: - the one HIGH still OPEN (no full-CI verdict exists for this line) and why #70 does not close it - auditor C revising its own report from MEDIUM to HIGH after finding its earlier evidence came from a stale log - auditor B's disclosure that one probe made real upstream calls - every MEDIUM/LOW still open, including B-M1, which is deliberately NOT rushed: re-keying the login lockout trades a guaranteed DoS for a possible brute-force hole - what could not be tested at all, unrounded — no real provider connection, and a page that would not render in one auditor's browser that the owner should confirm [doc-links] PASS [fabricated-docs] clean prettier clean Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release gate requires three independent audits with their findings consolidated. This is that record for
release/v3.8.55.Three auditors ran in parallel — architecture, offensive security, product/QA — each in its own worktree, without access to the others' conclusions, and each required to
git fetchand re-verify every finding against the current tip before reporting. The tree advanced under them (#53, #56, #64, #65, #66 merged mid-audit); all three confirmed by diff which of their findings survived.What the section records that a summary would lose
/v1/**answered anonymous internet callers becauserequireLogingoverns/api/**only — and the VM deployment guide prescribedREQUIRE_API_KEY=falsefor a public domain. My own 3.8.54 smoke test probed/api/**andGET /v1/models(gated by a different switch) and reported the image closed. That is written down./dashboard/costs/workspaceswould not render in auditor C's browser — not reported as a finding, because an untouched sibling page fails the same way, but flagged for the owner to confirm, with the consequence stated if it does not.npm audit --omit=dev0 vulnerabilities across 890 production deps, 314/314 authz tests, IDOR attacked from several angles without a hole, Host-spoofing and path-normalisation bypasses tried and failed.check:doc-linkscheck:fabricated-docsprettier --check🤖 Generated with Claude Code