fix(podman): the guidance pins a tag that exists, and the test agrees - #64
Merged
Merged
Conversation
#63 rewrote the docs from `:next` to `:latest` and broke `podman-machine-guidance-8497.test.ts`, which asserts the tag the podman guidance names. My regression, and the test was right to catch it: the Quadlet unit still said `:next` while the README next to it said `:latest`, so the guidance disagreed with itself. The test's own comment records why `:next` was pinned in Fase 8: `:latest` is only promoted by a SemVer publish, so pinning it here documented a pull that returns "manifest unknown" That was true when written. v3.8.54 shipped on 2026-09-19 and `:latest` resolves: docker manifest inspect ghcr.io/lmprado-dz23/omniroute:latest -> present docker manifest inspect ghcr.io/lmprado-dz23/omniroute:3.8.49 -> absent So the premise expired — the same class of staleness #63 fixed, one layer down. `contrib/podman/omniroute.container` now pins `:latest` like the README, and both assertions follow, with the comment rewritten to say why rather than leaving a reason that is no longer true. tests 7 / pass 7 / fail 0 eslint exit 0, prettier clean, [doc-links] PASS Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
LMPrado-DZ23
added a commit
that referenced
this pull request
Sep 20, 2026
…ion that shard 4 was failing on
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My regression from #63, and the test was right to catch it.
#63 rewrote the docs from
:nextto:latest.tests/unit/podman-machine-guidance-8497.test.tsasserts the tag the podman guidance names, so it went red on the base — proven by the agent working on #56, who ran it on the tip either side of that merge: 7/7 before, 6/7 after.It also exposed something #63 left half-done: I changed
contrib/podman/README.mdbut notcontrib/podman/omniroute.containernext to it, so the Quadlet unit still said:nextwhile the README said:latest. The guidance disagreed with itself.Why the original pin was right, and why it stopped being right
The test carries its own reasoning, from Fase 8:
Correct when written. v3.8.54 shipped on 2026-09-19:
The premise expired. This is the same class of staleness #63 fixed one layer up — a correct reason, recorded in a comment, that quietly became false when the world changed. So the comment is rewritten to state the new reason and the evidence, rather than leaving behind a justification that no longer holds.
Change
contrib/podman/omniroute.containerImage=…/omniroute:nextImage=…/omniroute:latestpodman-machine-guidance-8497.test.ts:next:latestThe test keeps its teeth: it still pins the tag the guidance names, so the next person who changes one and not the other gets the same failure I did.
tests/unit/podman-machine-guidance-8497.test.tseslint --max-warnings=0prettier --checkcheck:doc-links🤖 Generated with Claude Code