Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6177 +/- ##
==========================================
+ Coverage 85.08% 85.11% +0.03%
==========================================
Files 110 110
Lines 44654 44673 +19
==========================================
+ Hits 37993 38024 +31
+ Misses 6661 6649 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Walltime Performance ReportMerging #6177 will degrade performances by 10.39%Comparing
|
| Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|
| ⚡ | execute_dodecahedron |
1.7 s | 1.5 s | +12.57% |
| ❌ | execute_flange |
1.7 s | 1.9 s | -10.39% |
jtran
approved these changes
Apr 7, 2025
| let result = inner_inch(exec_state)?; | ||
|
|
||
| Ok(args.make_user_val_from_f64(result)) | ||
| Ok(args.make_user_val_from_f64_with_type(TyF64::new(result, exec_state.current_default_units()))) |
Contributor
There was a problem hiding this comment.
This is surprising, but makes sense.
nrc
force-pushed
the
nrc-uom-prop
branch
2 times, most recently
from
2fcb857 to
422a621
Compare
Signed-off-by: Nick Cameron <nrc@ncameron.org>
modeling-app-github-app bot
pushed a commit
that referenced
this pull request
Apr 7, 2025
Signed-off-by: Nick Cameron <nrc@ncameron.org>
modeling-app-github-app bot
pushed a commit
that referenced
this pull request
Apr 7, 2025
Signed-off-by: Nick Cameron <nrc@ncameron.org>
modeling-app-github-app bot
pushed a commit
that referenced
this pull request
Apr 7, 2025
Signed-off-by: Nick Cameron <nrc@ncameron.org>
modeling-app-github-app bot
pushed a commit
that referenced
this pull request
Apr 7, 2025
Signed-off-by: Nick Cameron <nrc@ncameron.org>
jessfraz
added a commit
that referenced
this pull request
Apr 7, 2025
* origin/main: Quick app rename typo fix in settings.md (#6198) Add point-and-click Insert from local project files (#6129) Install and start Vector on macOS CI runners (#6147) Implement polar std function in KCL (#6180) Bump typescript from 5.8.2 to 5.8.3 in /packages/codemirror-lsp-client in the patch group (#6188) Bump @types/node from 22.13.13 to 22.14.0 in /packages/codemirror-lsp-client in the minor group (#6189) Bump the major group in /packages/codemirror-lang-kcl with 2 updates (#6194) Bump taiki-e/install-action from 2.49.30 to 2.49.45 in the patch group (#6185) Bump the patch group with 6 updates (#6186) Bump the patch group in /rust/kcl-language-server with 3 updates (#6183) Bump the patch group in /packages/codemirror-lang-kcl with 2 updates (#6193) Remove unnecessary timeouts waiting for command bar (#6199) Stream handling / Stream idle mode v2; a ton of network related changes (ping; scene indicator -> stream indicator, stream resizing (even on pause)) (#5312) More propagation of numeric types (#6177) Apply type-directed coercions to arguments in calls of user functions (#6179) Erase comment start positions from snapshot tests (#6178) Implement coercion of numeric types for ascription and arithmetic (off by default) (#6175) Reduce the number of reps in the add_lots test (#6174) take things off the batch in a more safe way (#6171)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More carrying around numeric types rather than just using plain f64s. This is almost all of them, but there are a few left which depend on in-flight PRs. No user-facing changes. I also removed a few more deserialize derives.