Skip to content

take things off the batch in a more safe way#6171

Merged
jessfraz merged 1 commit intomainfrom
take_from_batch_safe
Apr 6, 2025
Merged

take things off the batch in a more safe way#6171
jessfraz merged 1 commit intomainfrom
take_from_batch_safe

Conversation

@jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Apr 5, 2025

found this while @paultag and i were doing parallel modules, easy to just put on main!

Signed-off-by: Jess Frazelle <github@jessfraz.com>
@qa-wolf
Copy link

qa-wolf bot commented Apr 5, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@jessfraz jessfraz requested a review from jtran April 5, 2025 23:54
@vercel
Copy link

vercel bot commented Apr 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Apr 6, 2025 0:05am

@codecov
Copy link

codecov bot commented Apr 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.34%. Comparing base (48e1a8e) to head (21a3582).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6171   +/-   ##
=======================================
  Coverage   85.34%   85.34%           
=======================================
  Files         110      110           
  Lines       44246    44248    +2     
=======================================
+ Hits        37763    37765    +2     
  Misses       6483     6483           
Flag Coverage Δ
rust 85.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jtran jtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 6, 2025

CodSpeed Walltime Performance Report

Merging #6171 will degrade performances by 17.19%

Comparing take_from_batch_safe (21a3582) with main (96e12b5)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 5 improvements
❌ 3 regressions
✅ 82 untouched benchmarks
🆕 2 new benchmarks
⁉️ 2 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
execute_80-20-rail 3.4 s 4.1 s -17.19%
⁉️ execute_a-parametric-bearing-pillow-block 2.7 s N/A N/A
⁉️ parse_a-parametric-bearing-pillow-block 1.8 ms N/A N/A
execute_exhaust-manifold 2.1 s 2.4 s -11.15%
execute_gridfinity-baseplate-magnets 5.6 s 4.8 s +15.42%
execute_i-beam 1.1 s 1.3 s -15%
execute_lego 3.1 s 2.5 s +24.56%
🆕 execute_parametric-bearing-pillow-block N/A 2.8 s N/A
🆕 parse_parametric-bearing-pillow-block N/A 1.9 ms N/A
parse_pipe 906.3 µs 421.2 µs ×2.2
execute_poopy-shoe 1.8 s 1.6 s +10.43%
parse_washer 707.2 µs 533.5 µs +32.55%

@jessfraz jessfraz merged commit 38446b5 into main Apr 6, 2025
59 checks passed
@jessfraz jessfraz deleted the take_from_batch_safe branch April 6, 2025 03:54
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 6, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 6, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 6, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 6, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 6, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 6, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 6, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 6, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 6, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 6, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 6, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 6, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 6, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 6, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 6, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 6, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 6, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 6, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 6, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 6, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 7, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 7, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 7, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
jessfraz added a commit that referenced this pull request Apr 7, 2025
* origin/main:
  Quick app rename typo fix in settings.md (#6198)
  Add point-and-click Insert from local project files (#6129)
  Install and start Vector on macOS CI runners (#6147)
  Implement polar std function in KCL (#6180)
  Bump typescript from 5.8.2 to 5.8.3 in /packages/codemirror-lsp-client in the patch group (#6188)
  Bump @types/node from 22.13.13 to 22.14.0 in /packages/codemirror-lsp-client in the minor group (#6189)
  Bump the major group in /packages/codemirror-lang-kcl with 2 updates (#6194)
  Bump taiki-e/install-action from 2.49.30 to 2.49.45 in the patch group (#6185)
  Bump the patch group with 6 updates (#6186)
  Bump the patch group in /rust/kcl-language-server with 3 updates (#6183)
  Bump the patch group in /packages/codemirror-lang-kcl with 2 updates (#6193)
  Remove unnecessary timeouts waiting for command bar (#6199)
  Stream handling / Stream idle mode v2; a ton of network related changes (ping; scene indicator -> stream indicator, stream resizing (even on pause)) (#5312)
  More propagation of numeric types (#6177)
  Apply type-directed coercions to arguments in calls of user functions (#6179)
  Erase comment start positions from snapshot tests (#6178)
  Implement coercion of numeric types for ascription and arithmetic (off by default) (#6175)
  Reduce the number of reps in the add_lots test (#6174)
  take things off the batch in a more safe way (#6171)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants