Skip to content

Reduce the number of reps in the add_lots test#6174

Merged
nrc merged 1 commit intomainfrom
nrc-add-lots
Apr 7, 2025
Merged

Reduce the number of reps in the add_lots test#6174
nrc merged 1 commit intomainfrom
nrc-add-lots

Conversation

@nrc
Copy link
Contributor

@nrc nrc commented Apr 6, 2025

As discussed on Slack, this reduces the number of operations in the add_lots test so that it passes locally.

Signed-off-by: Nick Cameron <nrc@ncameron.org>
@nrc nrc requested review from adamchalmers and jessfraz April 6, 2025 20:28
@qa-wolf
Copy link

qa-wolf bot commented Apr 6, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@vercel
Copy link

vercel bot commented Apr 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Apr 6, 2025 8:39pm

@codecov
Copy link

codecov bot commented Apr 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.37%. Comparing base (38446b5) to head (77dedb1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6174      +/-   ##
==========================================
+ Coverage   85.34%   85.37%   +0.02%     
==========================================
  Files         110      110              
  Lines       44248    44248              
==========================================
+ Hits        37765    37775      +10     
+ Misses       6483     6473      -10     
Flag Coverage Δ
rust 85.37% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nrc nrc enabled auto-merge (squash) April 6, 2025 21:19
@nrc nrc merged commit ce7a967 into main Apr 7, 2025
38 checks passed
@nrc nrc deleted the nrc-add-lots branch April 7, 2025 02:41
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 7, 2025
Signed-off-by: Nick Cameron <nrc@ncameron.org>
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 7, 2025
Signed-off-by: Nick Cameron <nrc@ncameron.org>
jessfraz added a commit that referenced this pull request Apr 7, 2025
* origin/main:
  Quick app rename typo fix in settings.md (#6198)
  Add point-and-click Insert from local project files (#6129)
  Install and start Vector on macOS CI runners (#6147)
  Implement polar std function in KCL (#6180)
  Bump typescript from 5.8.2 to 5.8.3 in /packages/codemirror-lsp-client in the patch group (#6188)
  Bump @types/node from 22.13.13 to 22.14.0 in /packages/codemirror-lsp-client in the minor group (#6189)
  Bump the major group in /packages/codemirror-lang-kcl with 2 updates (#6194)
  Bump taiki-e/install-action from 2.49.30 to 2.49.45 in the patch group (#6185)
  Bump the patch group with 6 updates (#6186)
  Bump the patch group in /rust/kcl-language-server with 3 updates (#6183)
  Bump the patch group in /packages/codemirror-lang-kcl with 2 updates (#6193)
  Remove unnecessary timeouts waiting for command bar (#6199)
  Stream handling / Stream idle mode v2; a ton of network related changes (ping; scene indicator -> stream indicator, stream resizing (even on pause)) (#5312)
  More propagation of numeric types (#6177)
  Apply type-directed coercions to arguments in calls of user functions (#6179)
  Erase comment start positions from snapshot tests (#6178)
  Implement coercion of numeric types for ascription and arithmetic (off by default) (#6175)
  Reduce the number of reps in the add_lots test (#6174)
  take things off the batch in a more safe way (#6171)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants