Use performance.now instead of Date.now #2583
Conversation
🦋 Changeset detectedLatest commit: 9e35f09 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
markijbema
left a comment
markijbema
left a comment
There was a problem hiding this comment.
Do we suspect we might have the same or similar problems elsewhere?
| const now = Date.now() | ||
| const now = performance.now() // kilocode_change | ||
| const timeSinceLastRequest = now - Task.lastGlobalApiRequestTime | ||
| const rateLimit = apiConfiguration?.rateLimitSeconds || 0 |
There was a problem hiding this comment.
We can try to fix it more aggressively by not waiting if rateLimit is zero anyway.
There was a problem hiding this comment.
That does make sense, i mean than we kan skip this altogether right?
There was a problem hiding this comment.
yeah, in fact if rateLimitDelay>rateLimit I think we're in trouble.
maybe Task.lastGlobalApiRequestTime being a global also causes problem.
We absolutely do. |
src/core/task/__tests__/Task.spec.ts
Outdated
| const mockTime = Date.now() + (mockApiConfig.rateLimitSeconds + 1) * 1000 | ||
| Date.now = vi.fn(() => mockTime) | ||
| // kilocode_change start: use performance instead of Date | ||
| const originalDateNow = performance.now |
Use performance.now instead of Date.now
Reported by email