Skip to content

Use performance.now instead of Date.now #2583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 23, 2025
Merged

Use performance.now instead of Date.now #2583

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9179209
Use performance.now instead of Date.now
chrarnoldus Sep 22, 2025
7970f9e
Merge branch 'main' into christiaan/performance-now
chrarnoldus Sep 23, 2025
2d95dc5
Fix mocks
chrarnoldus Sep 23, 2025
954eed2
The rate limit delay should never be greater than the configured limit
chrarnoldus Sep 23, 2025
0c13d2d
Update rate limiter to respect timeout limits changeset
chrarnoldus Sep 23, 2025
9e35f09
Rename
chrarnoldus Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/task/Task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2699,7 +2699,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
// Use the shared timestamp so that subtasks respect the same rate-limit
// window as their parent tasks.
if (Task.lastGlobalApiRequestTime) {
const now = Date.now()
const now = performance.now() // kilocode_change
const timeSinceLastRequest = now - Task.lastGlobalApiRequestTime
const rateLimit = apiConfiguration?.rateLimitSeconds || 0
Copy link
Collaborator Author

@chrarnoldus chrarnoldus Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can try to fix it more aggressively by not waiting if rateLimit is zero anyway.

Copy link
Contributor

@markijbema markijbema Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does make sense, i mean than we kan skip this altogether right?

Copy link
Collaborator Author

@chrarnoldus chrarnoldus Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, in fact if rateLimitDelay>rateLimit I think we're in trouble.

maybe Task.lastGlobalApiRequestTime being a global also causes problem.

rateLimitDelay = Math.ceil(Math.max(0, rateLimit * 1000 - timeSinceLastRequest) / 1000)
Expand All @@ -2717,7 +2717,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {

// Update last request time before making the request so that subsequent
// requests — even from new subtasks — will honour the provider's rate-limit.
Task.lastGlobalApiRequestTime = Date.now()
Task.lastGlobalApiRequestTime = performance.now() // kilocode_change

const systemPrompt = await this.getSystemPrompt()
this.lastUsedInstructions = systemPrompt
Expand Down
Loading