-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Use performance.now instead of Date.now #2583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9179209
Use performance.now instead of Date.now
chrarnoldus 7970f9e
Merge branch 'main' into christiaan/performance-now
chrarnoldus 2d95dc5
Fix mocks
chrarnoldus 954eed2
The rate limit delay should never be greater than the configured limit
chrarnoldus 0c13d2d
Update rate limiter to respect timeout limits changeset
chrarnoldus 9e35f09
Rename
chrarnoldus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "kilo-code": patch | ||
| --- | ||
|
|
||
| The rate limiter no longer generates timeouts longer than the configured limit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1114,9 +1114,11 @@ describe("Cline", () => { | |
| await parentIterator.next() | ||
|
|
||
| // Simulate time passing (more than rate limit) | ||
| const originalDateNow = Date.now | ||
| const mockTime = Date.now() + (mockApiConfig.rateLimitSeconds + 1) * 1000 | ||
| Date.now = vi.fn(() => mockTime) | ||
| // kilocode_change start: use performance instead of Date | ||
| const originalDateNow = performance.now | ||
|
||
| const mockTime = performance.now() + (mockApiConfig.rateLimitSeconds + 1) * 1000 | ||
| performance.now = vi.fn(() => mockTime) | ||
| // kilocode_change end | ||
|
|
||
| // Create a subtask after time has passed | ||
| const child = new Task({ | ||
|
|
@@ -1139,7 +1141,7 @@ describe("Cline", () => { | |
| expect(mockDelay).not.toHaveBeenCalled() | ||
|
|
||
| // Restore Date.now | ||
| Date.now = originalDateNow | ||
| performance.now = originalDateNow // kilocode_change | ||
| }) | ||
|
|
||
| it("should share rate limiting across multiple subtasks", async () => { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can try to fix it more aggressively by not waiting if
rateLimitis zero anyway.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That does make sense, i mean than we kan skip this altogether right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, in fact if rateLimitDelay>rateLimit I think we're in trouble.
maybe Task.lastGlobalApiRequestTime being a global also causes problem.