Skip to content

refactor(vscode): share context menu styles - #13659

Merged
marius-kilocode merged 2 commits into
mainfrom
dedupe-b-ui-fifth
Sep 1, 2026
Merged

refactor(vscode): share context menu styles#13659
marius-kilocode merged 2 commits into
mainfrom
dedupe-b-ui-fifth

Conversation

@marius-kilocode

@marius-kilocode marius-kilocode commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

What Problem This Solves

Agent Manager context menus and session-tab context menus repeat the same CSS declarations.

Why This Change Was Made

Group their existing single-class selectors in session-tabs.css and remove the Agent Manager copy. Both webviews already load this shared stylesheet. Keep declarations and selector specificity unchanged; no markup, behavior, dependencies, or test harness are added. Include this shared stylesheet in the existing CSS/TSX consistency checks without changing assertions or adding exceptions.

User Impact

No intended visual change. Menu width, border, shadow, item padding, highlight styling, and separator spacing retain the same values.

Evidence

  • Fresh branch from origin/main after PR refactor(vscode): share dropped mention text insertion #13656 merged. Two CSS files, an existing architecture test, and one allowlist removal: 5 additions, 44 deletions, net 39 fewer total lines and 28 fewer CSS lines.
  • Duplication report: 25 to 24 pairs, 490 to 468 duplicated lines, 3,391 to 3,236 duplicated tokens. Remove only fingerprint 73d7672dd2e6cd26.
  • Initial CI exposed the architecture test indexing only Agent Manager styles. Updated its two consistency checks to include the shared stylesheet, while leaving Agent Manager prefix restrictions unchanged. No retry or test bypass.
  • Full extension unit suite: 4,580 passed, one existing skip, zero failures. build:check including host/webview typecheck, lint and both bundles passed; knip, formatting and duplication/annotation guards passed. No tests added.
  • Visible isolated VS Code with fresh HOME and disposable Git fixture: created a test section through the UI, opened its context menu, and inspected the cropped screenshot. Both selectors produced identical computed values for eight style properties across 27 live menu elements. Confirmed 210px minimum width and 6px/10px item padding. No prompt/model calls or real credentials. stop-vscode --cleanup true and stop completed. Separate sidebar-tab and high-contrast flows were not manually exercised.

Agent Manager section context menu using shared menu styling

@kilo-code-bot

kilo-code-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)
  • packages/kilo-vscode/tests/unit/agent-manager-arch.test.ts
  • packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css
  • packages/kilo-vscode/webview-ui/src/styles/session-tabs.css
  • script/kilocode-duplication-allowlist.json
Previous Review Summary (commit f9360df)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit f9360df)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css
  • packages/kilo-vscode/webview-ui/src/styles/session-tabs.css
  • script/kilocode-duplication-allowlist.json

Reviewed by grok-4.6 · Input: 61K · Output: 8.1K · Cached: 367.1K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit e653957 into main Sep 1, 2026
33 checks passed
@marius-kilocode
marius-kilocode deleted the dedupe-b-ui-fifth branch September 1, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants