Skip to content

refactor(vscode): share context menu styles #13659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marius-kilocode merged 2 commits into from
Sep 1, 2026
Merged

refactor(vscode): share context menu styles #13659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9360df
refactor(vscode): share context menu styles
marius-kilocode Sep 1, 2026
5f617c1
test(vscode): include shared menu styles in architecture checks
marius-kilocode Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/kilo-vscode/tests/unit/agent-manager-arch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ const TSX_FILES = [
path.join(ROOT, "webview-ui/src/components/chat/TabDnd.tsx"),
path.join(ROOT, "webview-ui/diff-viewer/BaseBranchPicker.tsx"),
]
const SHARED_CSS = path.join(ROOT, "webview-ui/src/styles/session-tabs.css")
const TSX_FILE = TSX_FILES[0]!
const KEYBIND_DEFAULTS_FILE = path.join(ROOT, "webview-ui/agent-manager/keybind-defaults.ts")
const PROVIDER_FILE = path.join(ROOT, "src/agent-manager/AgentManagerProvider.ts")
Expand Down Expand Up @@ -145,7 +146,7 @@ describe("Agent Manager CSS Prefix", () => {

describe("Agent Manager CSS/TSX Consistency", () => {
it("all classes used in TSX should be defined in CSS", () => {
const css = readAllCss()
const css = readAllCss() + fs.readFileSync(SHARED_CSS, "utf-8")
const tsx = readAllTsx()

// Extract am- classes defined in CSS
Expand All @@ -162,7 +163,7 @@ describe("Agent Manager CSS/TSX Consistency", () => {
})

it("all am- classes defined in CSS should be used in TSX", () => {
const css = readAllCss()
const css = readAllCss() + fs.readFileSync(SHARED_CSS, "utf-8")
const tsx = readAllTsx()

// Extract am- classes defined in CSS
Expand Down
29 changes: 0 additions & 29 deletions packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4814,35 +4814,6 @@ body.vscode-high-contrast-light {
}
}

/* Context menu — restyle to match dropdown-menu visuals.
The kilo-ui ContextMenu component hardcodes its own data-component / data-slot
attributes after the prop spread, so we can't override them via props.
Instead we apply a class and re-declare the styles here. */

.am-ctx-menu {
min-width: 210px;
border: 1px solid color-mix(in oklch, var(--border-base) 50%, transparent) !important;
box-shadow: var(--shadow-md) !important;

[data-slot="context-menu-item"],
[data-slot="context-menu-checkbox-item"],
[data-slot="context-menu-radio-item"],
[data-slot="context-menu-sub-trigger"] {
padding: 6px 10px;
font-size: var(--font-size-small);
transition: none;

&:hover,
&[data-highlighted] {
background: var(--surface-raised-base-hover);
}
}

[data-slot="context-menu-separator"] {
margin: 4px 0;
}
}

/* Shared sortable inspector tabs. */

.am-tab-closable,
Expand Down
3 changes: 2 additions & 1 deletion packages/kilo-vscode/webview-ui/src/styles/session-tabs.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,8 @@
}

/* Match tab context menus to dropdown-menu visuals on every tab surface. */
.session-tab-menu {
.session-tab-menu,
.am-ctx-menu {
min-width: 210px;
border: 1px solid color-mix(in oklch, var(--border-base) 50%, transparent) !important;
box-shadow: var(--shadow-md) !important;
Expand Down
12 changes: 0 additions & 12 deletions script/kilocode-duplication-allowlist.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,18 +188,6 @@
"owner": "kilo-vscode",
"reason": "Existing duplication before the ratchet; remove through a focused, behavior-preserving extraction."
},
{
"files": [
"packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css",
"packages/kilo-vscode/webview-ui/src/styles/session-tabs.css"
],
"fingerprint": "73d7672dd2e6cd26",
"maxMatches": 1,
"maxTokens": 155,
"kind": "legacy",
"owner": "kilo-vscode",
"reason": "Existing duplication before the ratchet; remove through a focused, behavior-preserving extraction."
},
{
"files": [
"packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css",
Expand Down
Loading