refactor(vscode): share dropped mention text insertion - #13656
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (5 files)
Reviewed by grok-4.6 · Input: 176.9K · Output: 7K · Cached: 186K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 1, 2026 10:52
iscekic
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
The chat prompt and New Worktree dialog duplicate the text and caret calculation for dropped file mentions.
Why This Change Was Made
Share only the pure insertion calculation in the existing path-mentions utility. Keep path conversion, mention registration, prompt cancellation/persistence, focus, and textarea sizing local and in the same order. Preserve insertion at selectionStart without replacing selected text, the unconditional trailing space, and paths containing spaces.
User Impact
No intended behavior change. No new files, dependencies, or test harness. Add one small regression test to the existing path-mentions suite.
Evidence