Buffer Factory: Add configurability of BufferFactory. #105
Closed
KBaichoo wants to merge 7 commits intoacct-streamsfrom
Closed
Buffer Factory: Add configurability of BufferFactory. #105KBaichoo wants to merge 7 commits intoacct-streamsfrom
KBaichoo wants to merge 7 commits intoacct-streamsfrom
Conversation
Owner
Author
|
This builds on top of envoyproxy#17093. Since that's not yet merged I can't make an upstream PR on this, yet. Any initial feedback on this @antoniovicente |
|
envoyproxy#17093 is nearing merge. I recommend you look into some other things like implementation of accounts for H1 and H3 while this PR is blocked on review. |
Owner
Author
|
I'm finishing up tests for the final PR which will include the Overload Manager leveraging this mechanisms fully for H2 |
|
That sounds great. |
… there (envoyproxy#17548) Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: n/a Signed-off-by: Ulf Adams <ulf@engflow.com>
…ry. (envoyproxy#17093) This PR tracks memory accounts using >1MB of allocated space, with feedback mechanisms based on credits and debits on accounts. It further creates the handle from which the BufferMemoryAccount can reset the stream, and has the WatermarkBufferFactory also produce the particular BufferMemoryAccountImpl used for tracking. Risk Level: Medium Testing: Unit and Integration test Docs Changes: NA Release Notes: NA -- not yet user facing Platform Specific Features: NA Runtime guard: Yes, envoy.test_only.per_stream_buffer_accounting from envoyproxy#16218 sufficient Related Issue envoyproxy#15791 Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
use one destination port range rule to cover thousands of port rules in RBAC permissions, adding convenience for writing configuration and making matching quicker Risk Level: Low Testing: Unit Docs Changes: N/A Release Notes: Added Platform Specific Features: N/A Fixes envoyproxy#16039 Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>
account size to track. Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
Owner
Author
|
Closing this, made upstream PR: envoyproxy#17562 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can now set the minimum account size to track. This will be a PR against upstream once the dependent PR it builds upon is merged.
Signed-off-by: Kevin Baichoo kbaichoo@google.com
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes: TODO
Platform Specific Features: