[pull] unstable from apache:unstable #88
Open
+27,991
−5,561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…ng returned by name (#2148)
Currently, we're missing the 'version', 'role', 'modules' in the HELLO command which may cause compatibility issue in some clients like Java lettuce: ``` Caused by: java.lang.IllegalArgumentException: Version must not be null at io.lettuce.core.internal.LettuceAssert.notNull(LettuceAssert.java:71) at io.lettuce.core.RedisHandshake$RedisVersion.<init>(RedisHandshake.java:333) at io.lettuce.core.RedisHandshake$RedisVersion.of(RedisHandshake.java:362) at io.lettuce.core.RedisHandshake.applyPostHandshake(RedisHandshake.java:249) at io.lettuce.core.RedisHandshake.lambda$initialize$0(RedisHandshake.java:99) ``` For the HELLO command response refer: https://redis.io/commands/hello/
Co-authored-by: hulk <[email protected]>
Co-authored-by: 纪华裕 <[email protected]>
refer #2159 (comment) This PR is a temporary workaround for actions/runner-images#9491 to avoid blocking the PR merged. Can revert the change once the image issue is resolved.
Co-authored-by: 纪华裕 <[email protected]>
Co-authored-by: hulk <[email protected]>
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]> Co-authored-by: 纪华裕 <[email protected]> Co-authored-by: mwish <[email protected]>
Now actions/runner-images#9491 have been fixed and closed. This revert is #2161. I've tested and everything works fine.
…and (#2196) In Redis, it will add the migrating/importing slot section for the source and target node. For the migrating source node, it will contain the below section: ``` [{slot_id}->-{target_node_id}] ``` And for the importing node, it will add: ``` [{slot_id}-<-{source_node_id}] ```
Co-authored-by: hulk <[email protected]> Co-authored-by: Myth <[email protected]>
…ction feature (#2506) Co-authored-by: mwish <[email protected]>
…#2516) This closes #2512. Currently, the replication thread will wait for the worker's exclusive guard stop before closing db. But it now stops the worker from running new commands after acquiring the worker's exclusive guard, and it might cause deadlock if switches at the same time. The following steps will show how it may happen: - T0: client A sent `slaveof MASTER_IP0 MASTER_PORT0`, then the replication thread was started and waiting for the exclusive guard. - T1: client B sent `slaveof MASTER_IP1 MASTER_PORT1` and `AddMaster` will stop the previous replication thread, which is waiting for the exclusive guard. But the exclusive guard is acquired by the current thread. The workaround is also straightforward, just stop workers from running new commands by enabling `is_loading_` to true before acquiring the lock in the replication thread.
Co-authored-by: hulk <[email protected]>
…2527) Namespaces would store inside DB if the repl-namespace-enabled was set to yes. Then replicas will intercept and parse the increment replication log to see if it needs to reload namespaces. But it won't have the namespace update log when doing the full sync, so we need to reload from DB once the full replication is done.
Co-authored-by: Twice <[email protected]>
Co-authored-by: Twice <[email protected]>
…ync (#2549) Currently, the pre_fullsync_cb will stop the task runner and set the DB loading status to yes, but it didn't resume those states. This will cause the server to run in restoring status until success in resyncing from the master. To fix this, we need to call the post_fullsync_cb to resume those statuses before restarting full sync. This PR also uses try_lock to allow the replication thread to be stopped while preparing the restore db.
#2547) Co-authored-by: hulk <[email protected]>
Co-authored-by: hulk <[email protected]> Co-authored-by: Twice <[email protected]>
Co-authored-by: Twice <[email protected]>
Co-authored-by: Aleks Lozovyuk <[email protected]> Co-authored-by: Twice <[email protected]>
Co-authored-by: Twice <[email protected]> Co-authored-by: Twice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )