Fix the pidfile and backup_dir will be rewritten even though they weren't modified #2186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t modified Currently, the config's finish method will set a default value for pidfile and backup_dir, and this will cause them being rewrote into the config file.
caipengbo
previously approved these changes
Mar 20, 2024
jihuayu
approved these changes
Mar 21, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the config's finish method will set a default value for the pidfile
and backup_dir. And it will cause them to be rewritten into the config file.
Before applying this patch, it will generate two new lines
at the end of the file while rewriting: