chore: Enable -Werror=unused-parameter flag #2507
Conversation
| @@ -106,11 +106,6 @@ constexpr void SEED(const T x0, const T x1, const T x2) { | |||
| SET3(x, x0, x1, x2), SET3(a, A0, A1, A2), c = C; | |||
| } | |||
|
|
|||
| template <typename T> | |||
| constexpr T HiBit(const T x) { | |||
There was a problem hiding this comment.
This function appears to be unused.
There was a problem hiding this comment.
this is vendored ( pasted from other project )
Maybe we can disable lint for "vendor" dir?
There was a problem hiding this comment.
Even though it's in the vendored directory, I believe it's more of a modern C++ re-implementation based on the comment below. Therefore, removing the unused function should be acceptable, at least NFC.
Lines 44 to 47 in 5ecf023
|
I don't know why this test failed. I believe the entire patch should be NFC. Other CI failures have already been fixed in the latest patch. Please allow the CI to run. |
|
unused-parameterwarnings as errors in CMake #2266